-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Reland "[LLDB][NativePDB] Find functions by basename" ( #152295) #153160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JDevlieghere
merged 11 commits into
llvm:main
from
Nerixyz:feat/lldb-npdb-function-lookup
Aug 12, 2025
Merged
Reland "[LLDB][NativePDB] Find functions by basename" ( #152295) #153160
JDevlieghere
merged 11 commits into
llvm:main
from
Nerixyz:feat/lldb-npdb-function-lookup
Aug 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jonas Devlieghere <[email protected]>
Co-authored-by: Jonas Devlieghere <[email protected]>
Co-authored-by: Jonas Devlieghere <[email protected]>
Co-authored-by: Jonas Devlieghere <[email protected]>
Co-authored-by: Jonas Devlieghere <[email protected]>
Contributor
|
The following shell tests are broken on lldb-x86_64-win after this patch lldb-shell::process_load.cpp Please take a look and fix them ASAP. |
Michael137
pushed a commit
that referenced
this pull request
Aug 14, 2025
Some functions don't have the `FunctionType` set. We can't look these up and won't be able to call them, so ignore them when caching the function names. This does fix the failures caused by #153160 mentioned in #153160 (comment). However, in `lldb-shell::msstl_smoke.cpp` there's another failure not introduced by #153160 (fixed with #153386).
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 14, 2025
…okup (#153382) Some functions don't have the `FunctionType` set. We can't look these up and won't be able to call them, so ignore them when caching the function names. This does fix the failures caused by llvm/llvm-project#153160 mentioned in llvm/llvm-project#153160 (comment). However, in `lldb-shell::msstl_smoke.cpp` there's another failure not introduced by #153160 (fixed with #153386).
ZequanWu
added a commit
that referenced
this pull request
Sep 2, 2025
…stically. (#156530) #153160 created those function maps and uses default sort comparator which is not deterministic when there are multiple entries with same name because llvm::sort is unstable sort. This fixes it by comparing the id value when tie happens and sort `m_type_base_names` deterministically as well.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Sep 2, 2025
…s deterministically. (#156530) llvm/llvm-project#153160 created those function maps and uses default sort comparator which is not deterministic when there are multiple entries with same name because llvm::sort is unstable sort. This fixes it by comparing the id value when tie happens and sort `m_type_base_names` deterministically as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #152295.
Checking for the overloads did not account for them being out of order. For example, the failed output contained the overloads, but out of order. The last commit here fixes that by using
-DAG.