Skip to content

[LLDB][NativePDB] Ignore functions with no type in name lookup #153382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

[LLDB][NativePDB] Ignore functions with no type in name lookup #153382

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
509b83f
[LLDB][NativePDB] Ignore functions with no type in name lookup
Nerixyz Aug 13, 2025
8d72964
fix: use isSimple
Nerixyz Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1675,7 +1675,7 @@ void SymbolFileNativePDB::CacheFunctionNames() {
llvm::cantFail(SymbolDeserializer::deserializeAs<ProcSym>(*iter));
if ((proc.Flags & ProcSymFlags::IsUnreachable) != ProcSymFlags::None)
continue;
if (proc.Name.empty())
if (proc.Name.empty() || proc.FunctionType.isNoneType())
Copy link
Member

@Michael137 Michael137 Aug 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would proc.FunctionType.isSimple() be more robust? Or can FunctionType never be "simple"?

Copy link
Contributor Author

@Nerixyz Nerixyz Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it would be more robust, let's do that. I couldn't think of a case where the type would be simple and not none (i.e. a primitive type). But in that case, we should still skip the function.

continue;

// The function/procedure symbol only contains the demangled name.
Expand Down
Loading