Skip to content

[clang][analyzer] Relax assertion for non-default address spaces in the cstring checker #153498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 20, 2025
Merged

[clang][analyzer] Relax assertion for non-default address spaces in the cstring checker #153498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9b7fd48
Support non-default address spaces in the cstring checker
nuudlman Aug 13, 2025
72d5f2e
Merge branch 'main' into fix-cstring-checker
nuudlman Aug 13, 2025
22e3c62
Clean up test based on feedback
nuudlman Aug 15, 2025
2363494
Re-enable all unix checkers to ensure they are compatible with non-de…
nuudlman Aug 16, 2025
47db358
Use convenience method for extring the canonical and unqualified type
nuudlman Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1129,9 +1129,9 @@ bool CStringChecker::isFirstBufInBound(CheckerContext &C, ProgramStateRef State,
if (!ER)
return true; // cf top comment.

// FIXME: Does this crash when a non-standard definition
// of a library function is encountered?
Comment on lines -1132 to -1133
Copy link
Contributor

@NagyDonat NagyDonat Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this FIXME seems to be justified -- I tried declaring memcpy in a wildly nonstandard variant (with int * pointers) and there was no crash.

(No action expected, just mentioning this for other reviewers.)

assert(ER->getValueType() == C.getASTContext().CharTy &&
// Support library functions defined with non-default address spaces
assert(ER->getValueType()->getCanonicalTypeUnqualified() ==
C.getASTContext().CharTy &&
"isFirstBufInBound should only be called with char* ElementRegions");

// Get the size of the array.
Expand Down
18 changes: 17 additions & 1 deletion clang/test/Analysis/element-region-address-space.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,27 @@
// RUN: %clang_analyze_cc1 -triple amdgcn-unknown-unknown \
// RUN: -analyzer-checker=core -verify %s
// RUN: -Wno-incompatible-library-redeclaration \
// RUN: -analyzer-checker=core,unix -verify %s

// expected-no-diagnostics
//
// By default, pointers are 64-bits.
#define ADDRESS_SPACE_64BITS __attribute__((address_space(0)))
#define ADDRESS_SPACE_32BITS __attribute__((address_space(3)))

int test(ADDRESS_SPACE_32BITS int *p, ADDRESS_SPACE_32BITS void *q) {
return p == q; // no-crash
}

// Make sure that the cstring checker handles non-default address spaces
ADDRESS_SPACE_64BITS void *
memcpy(ADDRESS_SPACE_64BITS void *,
ADDRESS_SPACE_32BITS const void *,
long unsigned int);

ADDRESS_SPACE_64BITS struct {
char m[16];
} n;

void avoid_cstring_checker_crash(ADDRESS_SPACE_32BITS char *p) {
memcpy(&n.m[0], p, 4); // no-crash
}