[clang][LoongArch] Ensure target("lasx") implies LSX support
#153542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-backend-loongarch @llvm/pr-subscribers-clang Author: None (Ami-zhang) ChangesCurrently, Fixes #149512. Full diff: https://github.com/llvm/llvm-project/pull/153542.diff 2 Files Affected:
diff --git a/clang/lib/Basic/Targets/LoongArch.cpp b/clang/lib/Basic/Targets/LoongArch.cpp
index f6915df1520b7..33001b23f48c6 100644
--- a/clang/lib/Basic/Targets/LoongArch.cpp
+++ b/clang/lib/Basic/Targets/LoongArch.cpp
@@ -460,7 +460,12 @@ LoongArchTargetInfo::parseTargetAttr(StringRef Features) const {
break;
case AttrFeatureKind::Feature:
- Ret.Features.push_back("+" + Value.str());
+ if (Value == "lasx") {
+ Ret.Features.push_back("+lasx");
+ Ret.Features.push_back("+lsx");
+ } else {
+ Ret.Features.push_back("+" + Value.str());
+ }
break;
}
}
diff --git a/clang/test/CodeGen/LoongArch/targetattr-lasx.c b/clang/test/CodeGen/LoongArch/targetattr-lasx.c
new file mode 100644
index 0000000000000..28b06605289a8
--- /dev/null
+++ b/clang/test/CodeGen/LoongArch/targetattr-lasx.c
@@ -0,0 +1,16 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --check-globals all --version 5
+// RUN: %clang_cc1 -triple loongarch64 -target-feature -lsx -emit-llvm %s -o - | FileCheck %s
+
+__attribute__((target("lasx")))
+// CHECK-LABEL: define dso_local void @testlasx(
+// CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
+// CHECK-NEXT: [[ENTRY:.*:]]
+// CHECK-NEXT: ret void
+//
+void testlasx() {}
+//.
+// CHECK: attributes #[[ATTR0]] = { noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+64bit,+lasx,+lsx" }
+//.
+// CHECK: [[META0:![0-9]+]] = !{i32 1, !"wchar_size", i32 4}
+// CHECK: [[META1:![0-9]+]] = !{!"{{.*}}clang version {{.*}}"}
+//.
|
SixWeining
reviewed
Aug 14, 2025
Comment on lines
463
to
468
Contributor
There was a problem hiding this comment.
Suggested change
| if (Value == "lasx") { | |
| Ret.Features.push_back("+lasx"); | |
| Ret.Features.push_back("+lsx"); | |
| } else { | |
| Ret.Features.push_back("+" + Value.str()); | |
| } | |
| Ret.Features.push_back("+" + Value.str()); | |
| if (Value == "lasx") | |
| Ret.Features.push_back("+lsx"); |
Currently, `__attribute__((target("lasx")))` does not automatically
enable LSX support, causing Clang to fail with `-mno-lsx`. Since
LASX depends on LSX, enabling LASX should implicitly enable LSX to
avoid clang error.
Fixes llvm#149512.
|
Can it be backported to LLVM 21? |
Contributor
Author
Yes. |
Contributor
Author
Member
|
/pull-request #153739 |
tru
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Aug 18, 2025
…153542) Currently, `__attribute__((target("lasx")))` does not automatically enable LSX support, causing Clang to fail with `-mno-lsx`. Since LASX depends on LSX, enabling LASX should implicitly enable LSX to avoid clang error. Fixes llvm#149512. Depends on llvm#153541 (cherry picked from commit a1b6e7f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
__attribute__((target("lasx")))does not automaticallyenable LSX support, causing Clang to fail with
-mno-lsx. SinceLASX depends on LSX, enabling LASX should implicitly enable LSX to
avoid clang error.
Fixes #149512.
Depends on #153541