-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[Github] Remove call to llvm-project-tests from libclang tests #153876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Github] Remove call to llvm-project-tests from libclang tests #153876
Conversation
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis allows for removing llvm-project-tests.yml. This significantly Full diff: https://github.com/llvm/llvm-project/pull/153876.diff 1 Files Affected:
diff --git a/.github/workflows/libclang-python-tests.yml b/.github/workflows/libclang-python-tests.yml
index 50ef4acf2feb1..edd2f774621b6 100644
--- a/.github/workflows/libclang-python-tests.yml
+++ b/.github/workflows/libclang-python-tests.yml
@@ -25,17 +25,36 @@ on:
jobs:
check-clang-python:
# Build libclang and then run the libclang Python binding's unit tests.
+ # There is an issue running on "windows-2019".
+ # See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
name: Build and run Python unit tests
if: github.repository == 'llvm/llvm-project'
+ runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.13"]
- uses: ./.github/workflows/llvm-project-tests.yml
- with:
- build_target: check-clang-python
- projects: clang
- # There is an issue running on "windows-2019".
- # See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
- os_list: '["ubuntu-24.04"]'
- python_version: ${{ matrix.python-version }}
+ steps:
+ - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+ - name: Setup Python
+ uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
+ with:
+ python-version: ${{ matrix.python_version }}
+ - name: Setup ccache
+ uses: hendrikmuhs/ccache-action@a1209f81afb8c005c13b4296c32e363431bffea5 # v1.2.17
+ with:
+ max-size: 2G
+ key: spirv-ubuntu-24.04
+ variant: sccache
+ - name: Build and Test
+ run: |
+ mkdir build
+ cmake -GNinja \
+ -S llvm \
+ -B build \
+ -DCMAKE_BUILD_TYPE=Release \
+ -DLLVM_ENABLE_ASSERTIONS=ON \
+ -DCMAKE_C_COMPILER_LAUNCHER=sccache \
+ -DCMAKE_CXX_COMPILER_LAUNCHER=sccache \
+ -DLLVM_ENABLE_PROJECTS=clang
+ ninja -C build check-clang-python
|
DeinAlptraum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. A few comments:
Please also remove the .github/workflows/llvm-project-tests.yml entry under
on.push.paths & on.pull_request.paths in the workflow file.
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
This allows for removing llvm-project-tests.yml. This significantly reduces the complexity of this workflow (including the complexity of llvm-project-tests.yml) at the cost of a little bit of duplication with the other workflows that were also using llvm-project-tests.yml. Pull Request: llvm#153876
They were already dropped. |
Created using spr 1.3.6 [skip ci]
…ests This allows for removing llvm-project-tests.yml. This significantly reduces the complexity of this workflow (including the complexity of llvm-project-tests.yml) at the cost of a little bit of duplication with the other workflows that were also using llvm-project-tests.yml. Reviewers: tstellar, DeinAlptraum Reviewed By: DeinAlptraum Pull Request: llvm/llvm-project#153876
This allows for removing llvm-project-tests.yml. This significantly
reduces the complexity of this workflow (including the complexity of
llvm-project-tests.yml) at the cost of a little bit of duplication with
the other workflows that were also using llvm-project-tests.yml.