[Github] Remove call to llvm-project-tests from libclang tests #153876
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6
Member
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis allows for removing llvm-project-tests.yml. This significantly Full diff: https://github.com/llvm/llvm-project/pull/153876.diff 1 Files Affected:
diff --git a/.github/workflows/libclang-python-tests.yml b/.github/workflows/libclang-python-tests.yml
index 50ef4acf2feb1..edd2f774621b6 100644
--- a/.github/workflows/libclang-python-tests.yml
+++ b/.github/workflows/libclang-python-tests.yml
@@ -25,17 +25,36 @@ on:
jobs:
check-clang-python:
# Build libclang and then run the libclang Python binding's unit tests.
+ # There is an issue running on "windows-2019".
+ # See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
name: Build and run Python unit tests
if: github.repository == 'llvm/llvm-project'
+ runs-on: ubuntu-24.04
strategy:
fail-fast: false
matrix:
python-version: ["3.8", "3.13"]
- uses: ./.github/workflows/llvm-project-tests.yml
- with:
- build_target: check-clang-python
- projects: clang
- # There is an issue running on "windows-2019".
- # See https://github.com/llvm/llvm-project/issues/76601#issuecomment-1873049082.
- os_list: '["ubuntu-24.04"]'
- python_version: ${{ matrix.python-version }}
+ steps:
+ - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+ - name: Setup Python
+ uses: actions/setup-python@42375524e23c412d93fb67b49958b491fce71c38 # v5.4.0
+ with:
+ python-version: ${{ matrix.python_version }}
+ - name: Setup ccache
+ uses: hendrikmuhs/ccache-action@a1209f81afb8c005c13b4296c32e363431bffea5 # v1.2.17
+ with:
+ max-size: 2G
+ key: spirv-ubuntu-24.04
+ variant: sccache
+ - name: Build and Test
+ run: |
+ mkdir build
+ cmake -GNinja \
+ -S llvm \
+ -B build \
+ -DCMAKE_BUILD_TYPE=Release \
+ -DLLVM_ENABLE_ASSERTIONS=ON \
+ -DCMAKE_C_COMPILER_LAUNCHER=sccache \
+ -DCMAKE_CXX_COMPILER_LAUNCHER=sccache \
+ -DLLVM_ENABLE_PROJECTS=clang
+ ninja -C build check-clang-python
|
Contributor
DeinAlptraum
left a comment
DeinAlptraum
left a comment
There was a problem hiding this comment.
Sounds good. A few comments:
Please also remove the .github/workflows/llvm-project-tests.yml entry under
on.push.paths & on.pull_request.paths in the workflow file.
Created using spr 1.3.6 [skip ci]
Created using spr 1.3.6 [skip ci]
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Aug 16, 2025
This allows for removing llvm-project-tests.yml. This significantly reduces the complexity of this workflow (including the complexity of llvm-project-tests.yml) at the cost of a little bit of duplication with the other workflows that were also using llvm-project-tests.yml. Pull Request: llvm#153876
Contributor
Author
They were already dropped. |
DeinAlptraum
approved these changes
Aug 17, 2025
Created using spr 1.3.6 [skip ci]
boomanaiden154
changed the base branch from
users/boomanaiden154/main.github-remove-call-to-llvm-project-tests-from-libclang-tests
to
main
boomanaiden154
deleted the
users/boomanaiden154/github-remove-call-to-llvm-project-tests-from-libclang-tests
branch
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Aug 18, 2025
…ests This allows for removing llvm-project-tests.yml. This significantly reduces the complexity of this workflow (including the complexity of llvm-project-tests.yml) at the cost of a little bit of duplication with the other workflows that were also using llvm-project-tests.yml. Reviewers: tstellar, DeinAlptraum Reviewed By: DeinAlptraum Pull Request: llvm/llvm-project#153876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for removing llvm-project-tests.yml. This significantly
reduces the complexity of this workflow (including the complexity of
llvm-project-tests.yml) at the cost of a little bit of duplication with
the other workflows that were also using llvm-project-tests.yml.