diff --git a/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp b/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp index 593a4f85d1309..79cd4bbcc9a60 100644 --- a/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp +++ b/clang-tools-extra/clang-tidy/cppcoreguidelines/PreferMemberInitializerCheck.cpp @@ -191,6 +191,9 @@ void PreferMemberInitializerCheck::check( if (!AssignmentToMember) continue; const FieldDecl *Field = AssignmentToMember->Field; + // Skip if the field is inherited from a base class. + if (Field->getParent() != Class) + continue; const Expr *InitValue = AssignmentToMember->Init; updateAssignmentLevel(Field, InitValue, Ctor, AssignedFields); if (!canAdvanceAssignment(AssignedFields[Field])) diff --git a/clang-tools-extra/docs/ReleaseNotes.rst b/clang-tools-extra/docs/ReleaseNotes.rst index 1553f461634d0..c8374ce33dc7a 100644 --- a/clang-tools-extra/docs/ReleaseNotes.rst +++ b/clang-tools-extra/docs/ReleaseNotes.rst @@ -163,6 +163,10 @@ Changes in existing checks an additional matcher that generalizes the copy-and-swap idiom pattern detection. +- Improved :doc:`cppcoreguidelines-prefer-member-initializer + ` check to + avoid false positives on inherited members in class templates. + - Improved :doc:`misc-header-include-cycle ` check performance. diff --git a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp index 7d6164946fc3d..e8d7db17f3c60 100644 --- a/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/prefer-member-initializer.cpp @@ -650,3 +650,16 @@ struct InitFromBindingDecl { } }; } // namespace GH82970 + +struct A { + int m; +}; + +struct B : A { + B() { m = 0; } +}; + +template +struct C : A { + C() { m = 0; } +};