[OpenMP][OMPD] Fix GDB plugin to work correctly when installed #153956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `sys.path` logic in the GDB plugin to insert the intended self-path in the first position rather than appending it to the end. The latter implied that if `sys.path` (naturally) contained the GDB's `gdb-plugin` directory, `import ompd` would return the top-level `ompd/__init__.py` module rather than the `ompd/ompd.py` submodule, as intended by adding the `ompd/` directory to `sys.path`. This is intended to be a minimal change necessary to fix the issue. Alternatively, the code could be modified to import `ompd.ompd` and stop modifying `sys.path` entirely. However, I do not know why this option was chosen in teh first place, so I can't tell if this won't break something. Fixes llvm#153954 Signed-off-by: Michał Górny <[email protected]>
llvmbot
added
openmp:libomp
Member
Author
|
@jhuber6 , could you please take a look at this? I think it's reasonably trivial, and it's the last blocker for OpenMP for me. |
jhuber6
approved these changes
Aug 20, 2025
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
sys.pathlogic in the GDB plugin to insert the intended self-path in the first position rather than appending it to the end. The latter implied that ifsys.path(naturally) contained the GDB'sgdb-plugindirectory,import ompdwould return the top-levelompd/__init__.pymodule rather than theompd/ompd.pysubmodule, as intended by adding theompd/directory tosys.path.This is intended to be a minimal change necessary to fix the issue. Alternatively, the code could be modified to import
ompd.ompdand stop modifyingsys.pathentirely. However, I do not know why this option was chosen in the first place, so I can't tell if this won't break something.Fixes #153954