[Sanitizers][Test] XFAIL array cookie tests on arm #154031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Poisoning of C++ array redzones is only implemented for x86 CPUs. New arm64 bots are being brought up, where these test fail. Original C++ arrays shadow poisoning change: http://reviews.llvm.org/D4774 rdar://158025391
llvmbot
added
compiler-rt
compiler-rt:asan
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Mariusz Borsa (wrotki) ChangesPoisoning of C++ array redzones is only implemented for x86 CPUs. New arm64 bots are being brought up, where these test fail. Original C++ arrays shadow poisoning change: rdar://158025391 Full diff: https://github.com/llvm/llvm-project/pull/154031.diff 2 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Posix/new_array_cookie_test.cpp b/compiler-rt/test/asan/TestCases/Posix/new_array_cookie_test.cpp
index edbdb4016d86e..fa896128cdb72 100644
--- a/compiler-rt/test/asan/TestCases/Posix/new_array_cookie_test.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/new_array_cookie_test.cpp
@@ -6,6 +6,9 @@
// UNSUPPORTED: ios
+// Poisoning C++ array redzones is not implemented on arm
+// XFAIL: target=arm{{.*}}
+
#include <stdio.h>
#include <stdlib.h>
struct C {
diff --git a/compiler-rt/test/asan/TestCases/Posix/new_array_cookie_uaf_test.cpp b/compiler-rt/test/asan/TestCases/Posix/new_array_cookie_uaf_test.cpp
index 335a56757d296..63b1171df0aef 100644
--- a/compiler-rt/test/asan/TestCases/Posix/new_array_cookie_uaf_test.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/new_array_cookie_uaf_test.cpp
@@ -5,6 +5,9 @@
// UNSUPPORTED: ios
+// Poisoning C++ array redzones is not implemented on arm
+// XFAIL: target=arm{{.*}}
+
#include <stdio.h>
#include <stdlib.h>
#include <assert.h>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poisoning of C++ array redzones is only implemented for x86 CPUs. New arm64 bots are being brought up, where these test fail.
Original C++ arrays shadow poisoning change:
http://reviews.llvm.org/D4774
rdar://158025391