-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[RISCV] Add changes to have better coverage for qc.insb and qc.insbi #154135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
8a73933
e4f25a4
9da2bdf
5a308b2
98fde9a
6401ada
b519505
857817b
e9a4a1f
15a00a7
e83a5cd
7886a00
817777c
253d600
eff65c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16112,6 +16112,13 @@ static SDValue combineXorToBitfieldInsert(SDNode *N, SelectionDAG &DAG, | |
| m_Value(Inserted)))))) | ||
| return SDValue(); | ||
|
|
||
| KnownBits Known = DAG.computeKnownBits(Inserted); | ||
|
||
|
|
||
| // Check if all zero bits in CMask are also zero in Inserted | ||
| APInt CMaskZeroBits = ~CMask; | ||
| if (!CMaskZeroBits.isSubsetOf(Known.Zero)) | ||
| return SDValue(); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Computing known bits is much more difficult than e.g. looking at the value type or checking if something is a shifted mask. Can you re-order this check to after the other two checks for efficiency?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved it. |
||
|
|
||
| if (N->getValueType(0) != MVT::i32) | ||
| return SDValue(); | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.