Skip to content

[lldb] Use SmallPtrSet directly instead of SmallSet (NFC) #154472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 1 commit into from
Aug 20, 2025
Merged

[lldb] Use SmallPtrSet directly instead of SmallSet (NFC) #154472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,9 +284,10 @@ bool DWARFDebugInfoEntry::GetDIENamesAndRanges(
/// Adds all attributes of the DIE at the top of the \c worklist to the
/// \c attributes list. Specifcations and abstract origins are added
/// to the \c worklist if the referenced DIE has not been seen before.
static bool GetAttributes(llvm::SmallVectorImpl<DWARFDIE> &worklist,
llvm::SmallSet<DWARFDebugInfoEntry const *, 3> &seen,
DWARFAttributes &attributes) {
static bool
GetAttributes(llvm::SmallVectorImpl<DWARFDIE> &worklist,
llvm::SmallPtrSet<DWARFDebugInfoEntry const *, 3> &seen,
DWARFAttributes &attributes) {
assert(!worklist.empty() && "Need at least one DIE to visit.");
assert(seen.size() >= 1 &&
"Need to have seen at least the currently visited entry.");
Expand Down Expand Up @@ -366,7 +367,7 @@ DWARFAttributes DWARFDebugInfoEntry::GetAttributes(const DWARFUnit *cu,
// Keep track if DIEs already seen to prevent infinite recursion.
// Value of '3' was picked for the same reason that
// DWARFDie::findRecursively does.
llvm::SmallSet<DWARFDebugInfoEntry const *, 3> seen;
llvm::SmallPtrSet<DWARFDebugInfoEntry const *, 3> seen;
seen.insert(this);

do {
Expand Down
Loading