From 1939bd339e88ef5b3d2df31c73aaafefad038b1e Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Thu, 21 Aug 2025 10:00:31 -0700 Subject: [PATCH 1/2] [TableGen] Remove unnecessary use of utostr when writing to raw_ostream. NFC --- llvm/utils/TableGen/CodeEmitterGen.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/llvm/utils/TableGen/CodeEmitterGen.cpp b/llvm/utils/TableGen/CodeEmitterGen.cpp index d7b5e21c3f1fb..a58fa9f79a8f0 100644 --- a/llvm/utils/TableGen/CodeEmitterGen.cpp +++ b/llvm/utils/TableGen/CodeEmitterGen.cpp @@ -154,9 +154,9 @@ bool CodeEmitterGen::addCodeToMergeInOperand(const Record *R, raw_string_ostream CaseOS(Case); CaseOS << indent(6); if (UseAPInt) { - CaseOS << EncoderMethodName << "(MI, " + utostr(OpIdx) << ", op"; + CaseOS << EncoderMethodName << "(MI, " << OpIdx << ", op"; } else { - CaseOS << "op = " << EncoderMethodName << "(MI, " << utostr(OpIdx); + CaseOS << "op = " << EncoderMethodName << "(MI, " << OpIdx; } CaseOS << ", Fixups, STI);\n"; } else { @@ -388,8 +388,7 @@ void CodeEmitterGen::addInstructionCasesForEncoding( static void emitInstBits(raw_ostream &OS, const APInt &Bits) { for (unsigned I = 0; I < Bits.getNumWords(); ++I) - OS << ((I > 0) ? ", " : "") << "UINT64_C(" << utostr(Bits.getRawData()[I]) - << ")"; + OS << ((I > 0) ? ", " : "") << "UINT64_C(" << Bits.getRawData()[I] << ")"; } void CodeEmitterGen::emitInstructionBaseValues( From 84a17c8dea32850be52c57c811e39d4f121b8273 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Thu, 21 Aug 2025 14:39:54 -0700 Subject: [PATCH 2/2] fixup! address review comment --- llvm/utils/TableGen/CodeEmitterGen.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/llvm/utils/TableGen/CodeEmitterGen.cpp b/llvm/utils/TableGen/CodeEmitterGen.cpp index 312a3f8ed72ea..7479a31e5078e 100644 --- a/llvm/utils/TableGen/CodeEmitterGen.cpp +++ b/llvm/utils/TableGen/CodeEmitterGen.cpp @@ -153,11 +153,10 @@ bool CodeEmitterGen::addCodeToMergeInOperand(const Record *R, if (!EncoderMethodName.empty()) { raw_string_ostream CaseOS(Case); CaseOS << indent(6); - if (UseAPInt) { + if (UseAPInt) CaseOS << EncoderMethodName << "(MI, " << OpIdx << ", op"; - } else { + else CaseOS << "op = " << EncoderMethodName << "(MI, " << OpIdx; - } CaseOS << ", Fixups, STI);\n"; } else { if (UseAPInt) {