-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[clang-repl] Sink RemoteJITUtils into Interpreter class (NFC) #155140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
79849c3
pipes for redirection in oop jit
825f005
Merge branch 'main' into redirection
kr-2003 52b0902
refactoring
3b4fcad
refactoring
e174e98
commenting & refactoring
b744a9f
compiler-rt conditional addition
0c6c995
Merge branch 'main' into redirection
kr-2003 2cf71ed
removed compiler-rt dep
7c29008
Merge branch 'redirection' of https://github.com/kr-2003/llvm-project…
41f8e54
separate file for oop tests
4f1d203
separate file for oop tests
a6a4369
separate file for oop tests
63de886
test file rename
c24e84e
test file rename
b114bb8
test file rename
850b953
resolving comments & InterpreterRemoteTest
956f393
resolving comments
14e5afd
resolving comments
65afbff
Custom lambda in launchExecutor and pid retrieval
7dc6590
Merge branch 'main' of https://github.com/llvm/llvm-project into redi…
095a63b
Dynamic path resolution
2b6dc6c
Dynamic path resolution using IncrementalCB
7ad10a6
Dynamic path resolution using IncrementalCB
6a58d5f
Addressing reviews
f1b9135
Sinking JitBuilder into Interpreter
dd73052
RemoteJITUtils shifted to IncrementalExecutor
e90df55
RemoteJITUtils shifted to IncrementalExecutor
521be31
Removed custom fork in launchExecutor lambda
baaff1e
Merge branch 'main' into redirection
kr-2003 44cde65
refactoring changes
fc1f0da
Merge branch 'redirection' of https://github.com/kr-2003/llvm-project…
c49ec55
Refactoring
a6a05ea
Deleted RemoteJITUtils.h & .cpp
f2ca64e
Refactoring
0c99b67
Refactoring
51d6657
Refactoring
a71c546
formatting
37a9f3d
formatting
2cdb210
Addressing reviews
129a62b
Addressing reviews
c856255
Addressing reviews
3a15ddf
Fix connectTCPSocket on non-unix
54a0dba
Fixing ambiguity and resolving comments
98c59b4
Fixing ambiguity and resolving comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From discussion with @vgvassilev it sounds like the motivation here was to defer creation of the
LLJITBuilderuntil you can ask the driver for the runtime path?This solves that problem, but eliminates the ability to configure the builder.
What if you added a new member and callback along the lines of:
then in the setup path you'd have something like:
The extra indirection gives you the opportunity to ask the driver for the path (if one isn't provided) while still giving the client the opportunity to configure the LLJITBuilder.