diff --git a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td index 721f9f6b320ad..ecd833bd9572e 100644 --- a/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td +++ b/mlir/include/mlir/Dialect/EmitC/IR/EmitC.td @@ -873,7 +873,7 @@ def EmitC_IncludeOp let hasCustomAssemblyFormat = 1; } -def EmitC_LiteralOp : EmitC_Op<"literal", [Pure]> { +def EmitC_LiteralOp : EmitC_Op<"literal", [Pure, CExpressionInterface]> { let summary = "Literal operation"; let description = [{ The `emitc.literal` operation produces an SSA value equal to some constant @@ -896,6 +896,12 @@ def EmitC_LiteralOp : EmitC_Op<"literal", [Pure]> { let hasVerifier = 1; let assemblyFormat = "$value attr-dict `:` type($result)"; + + let extraClassDeclaration = [{ + bool hasSideEffects() { + return false; + } + }]; } def EmitC_LogicalAndOp : EmitC_BinaryOp<"logical_and", []> { diff --git a/mlir/lib/Dialect/EmitC/Transforms/FormExpressions.cpp b/mlir/lib/Dialect/EmitC/Transforms/FormExpressions.cpp index 2f3e2618f4d74..b6fee09770ee7 100644 --- a/mlir/lib/Dialect/EmitC/Transforms/FormExpressions.cpp +++ b/mlir/lib/Dialect/EmitC/Transforms/FormExpressions.cpp @@ -36,9 +36,9 @@ struct FormExpressionsPass // Wrap each C operator op with an expression op. OpBuilder builder(context); auto matchFun = [&](Operation *op) { - if (isa(*op) && - !op->getParentOfType() && - op->getNumResults() == 1) + if (op->getNumResults() == 1 && !isa(op) && + isa(*op) && + !op->getParentOfType()) createExpression(op, builder); }; rootOp->walk(matchFun); diff --git a/mlir/lib/Target/Cpp/TranslateToCpp.cpp b/mlir/lib/Target/Cpp/TranslateToCpp.cpp index a5bd80e9d6b8b..ec8c03c04244f 100644 --- a/mlir/lib/Target/Cpp/TranslateToCpp.cpp +++ b/mlir/lib/Target/Cpp/TranslateToCpp.cpp @@ -100,6 +100,7 @@ static FailureOr getOperatorPrecedence(Operation *operation) { .Case([&](auto op) { return 17; }) .Case([&](auto op) { return 13; }) .Case([&](auto op) { return 16; }) + .Case([&](auto op) { return 17; }) .Case([&](auto op) { return 4; }) .Case([&](auto op) { return 15; }) .Case([&](auto op) { return 3; }) @@ -452,6 +453,16 @@ static LogicalResult printOperation(CppEmitter &emitter, emitc::LoadOp loadOp) { return emitter.emitOperand(loadOp.getOperand()); } +static LogicalResult printOperation(CppEmitter &emitter, + emitc::LiteralOp literalOp) { + // If literalOp is used inside an expression, we treat it as an inlined one. + if (emitter.isPartOfCurrentExpression(literalOp.getResult())) + return emitter.ostream() << literalOp.getValue(), success(); + + emitter.cacheDeferredOpResult(literalOp.getResult(), literalOp.getValue()); + return success(); +} + static LogicalResult printBinaryOperation(CppEmitter &emitter, Operation *operation, StringRef binaryOperator) { @@ -1714,10 +1725,10 @@ LogicalResult CppEmitter::emitOperation(Operation &op, bool trailingSemicolon) { emitc::DeclareFuncOp, emitc::DivOp, emitc::ExpressionOp, emitc::FieldOp, emitc::FileOp, emitc::ForOp, emitc::FuncOp, emitc::GlobalOp, emitc::IfOp, emitc::IncludeOp, emitc::LoadOp, - emitc::LogicalAndOp, emitc::LogicalNotOp, emitc::LogicalOrOp, - emitc::MulOp, emitc::RemOp, emitc::ReturnOp, emitc::SubOp, - emitc::SwitchOp, emitc::UnaryMinusOp, emitc::UnaryPlusOp, - emitc::VariableOp, emitc::VerbatimOp>( + emitc::LiteralOp, emitc::LogicalAndOp, emitc::LogicalNotOp, + emitc::LogicalOrOp, emitc::MulOp, emitc::RemOp, emitc::ReturnOp, + emitc::SubOp, emitc::SwitchOp, emitc::UnaryMinusOp, + emitc::UnaryPlusOp, emitc::VariableOp, emitc::VerbatimOp>( [&](auto op) { return printOperation(*this, op); }) // Func ops. @@ -1731,10 +1742,6 @@ LogicalResult CppEmitter::emitOperation(Operation &op, bool trailingSemicolon) { cacheDeferredOpResult(op.getResult(), op.getFieldName()); return success(); }) - .Case([&](auto op) { - cacheDeferredOpResult(op.getResult(), op.getValue()); - return success(); - }) .Case([&](auto op) { cacheDeferredOpResult(op.getResult(), createMemberAccess(op)); return success(); diff --git a/mlir/test/Target/Cpp/expressions.mlir b/mlir/test/Target/Cpp/expressions.mlir index 4281f41d0b3fb..09748505d3563 100644 --- a/mlir/test/Target/Cpp/expressions.mlir +++ b/mlir/test/Target/Cpp/expressions.mlir @@ -458,3 +458,45 @@ emitc.func @expression_with_call_opaque_with_args_array(%0 : i32, %1 : i32) { } return } + + +// CPP-DEFAULT: bool expression_with_literal(int32_t [[VAL_1:v[0-9]+]]) { +// CPP-DEFAULT-NEXT: bool [[VAL_2:v[0-9]+]] = (1 + [[VAL_1]]) / 2 < 3; +// CPP-DEFAULT-NEXT: return [[VAL_2]]; +// CPP-DEFAULT-NEXT: } + +// CPP-DECLTOP: bool expression_with_literal(int32_t [[VAL_1:v[0-9]+]]) { +// CPP-DECLTOP-NEXT: bool [[VAL_2:v[0-9]+]]; +// CPP-DECLTOP-NEXT: [[VAL_2]] = (1 + [[VAL_1]]) / 2 < 3; +// CPP-DECLTOP-NEXT: return [[VAL_2]]; +// CPP-DECLTOP-NEXT: } + +func.func @expression_with_literal(%arg0 : i32) -> i1 { + %ret = emitc.expression %arg0 noinline : (i32) -> i1 { + %literal1 = emitc.literal "1" : i32 + %literal2 = emitc.literal "2" : i32 + %add = add %literal1, %arg0 : (i32, i32) -> i32 + %div = div %add, %literal2 : (i32, i32) -> i32 + %literal3 = emitc.literal "3" : i32 + %cmp = emitc.cmp lt, %div, %literal3 : (i32, i32) -> i1 + emitc.yield %cmp : i1 + } + return %ret : i1 +} + + +// CPP-DEFAULT: int32_t single_literal_in_expression() { +// CPP-DEFAULT-NEXT: return 42; +// CPP-DEFAULT-NEXT: } + +// CPP-DECLTOP: int32_t single_literal_in_expression() { +// CPP-DECLTOP-NEXT: return 42; +// CPP-DECLTOP-NEXT: } + +func.func @single_literal_in_expression() -> i32 { + %ret = emitc.expression : () -> i32 { + %literal = emitc.literal "42" : i32 + emitc.yield %literal : i32 + } + return %ret : i32 +}