Skip to content

[analyzer] Clean up bug types in CallAndMessageChecker #156073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2025
+102 −187
Merged

[analyzer] Clean up bug types in CallAndMessageChecker #156073

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1106657
[analyzer] Clean up bug types in CallAndMessageChecker
NagyDonat Aug 29, 2025
eef2e29
Delete unused data member
NagyDonat Sep 1, 2025
79ea51c
Modernize variable names of bug types
NagyDonat Sep 2, 2025
e5e668d
Fix a typo
NagyDonat Sep 2, 2025
ad1f0c0
Use reference instead of pointer that cannot be null
NagyDonat Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
105 changes: 43 additions & 62 deletions clang/include/clang/StaticAnalyzer/Checkers/Checkers.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,68 +143,49 @@ def BitwiseShiftChecker : Checker<"BitwiseShift">,
]>,
Documentation<HasDocumentation>;

def CallAndMessageModeling : Checker<"CallAndMessageModeling">,
HelpText<"Responsible for essential modeling and assumptions after a "
"function/method call. For instance, if we can't reason about the "
"nullability of the implicit this parameter after a method call, "
"this checker conservatively assumes it to be non-null">,
Documentation<HasDocumentation>,
Hidden;

def CallAndMessageChecker : Checker<"CallAndMessage">,
HelpText<"Check for logical errors for function calls and Objective-C "
"message expressions (e.g., uninitialized arguments, null function "
"pointers)">,
CheckerOptions<[
CmdLineOption<Boolean,
"FunctionPointer",
"Check whether a called function pointer is null or "
"undefined",
"true",
Released>,
CmdLineOption<Boolean,
"ParameterCount",
"Check whether a function was called with the appropriate "
"number of arguments",
"true",
Released>,
CmdLineOption<Boolean,
"CXXThisMethodCall",
"Check whether the implicit this parameter is null or "
"undefined upon a method call",
"true",
Released>,
CmdLineOption<Boolean,
"CXXDeallocationArg",
"Check whether the argument of operator delete is undefined",
"true",
Released>,
CmdLineOption<Boolean,
"ArgInitializedness",
"Check whether any of the pass-by-value parameters is "
"undefined",
"true",
Released>,
CmdLineOption<Boolean,
"ArgPointeeInitializedness",
"Check whether the pointee of a pass-by-reference or "
"pass-by-pointer is undefined",
"false",
InAlpha>,
CmdLineOption<Boolean,
"NilReceiver",
"Check whether the reciever in the message expression is nil",
"true",
Released>,
CmdLineOption<Boolean,
"UndefReceiver",
"Check whether the reciever in the message expression is "
"undefined",
"true",
Released>,
]>,
Documentation<HasDocumentation>,
Dependencies<[CallAndMessageModeling]>;
def CallAndMessageChecker
: Checker<"CallAndMessage">,
HelpText<
"Check for logical errors for function calls and Objective-C "
"message expressions (e.g., uninitialized arguments, null function "
"pointers)">,
CheckerOptions<
[CmdLineOption<Boolean, "FunctionPointer",
"Check whether a called function pointer is null or "
"undefined",
"true", Released>,
CmdLineOption<
Boolean, "ParameterCount",
"Check whether a function was called with the appropriate "
"number of arguments",
"true", Released>,
CmdLineOption<Boolean, "CXXThisMethodCall",
"Check whether the implicit this parameter is null or "
"undefined upon a method call",
"true", Released>,
CmdLineOption<
Boolean, "CXXDeallocationArg",
"Check whether the argument of operator delete is undefined",
"true", Released>,
CmdLineOption<Boolean, "ArgInitializedness",
"Check whether any of the pass-by-value parameters is "
"undefined",
"true", Released>,
CmdLineOption<Boolean, "ArgPointeeInitializedness",
"Check whether the pointee of a pass-by-reference or "
"pass-by-pointer is undefined",
"false", InAlpha>,
CmdLineOption<
Boolean, "NilReceiver",
"Check whether the reciever in the message expression is nil",
"true", Released>,
CmdLineOption<
Boolean, "UndefReceiver",
"Check whether the reciever in the message expression is "
"undefined",
"true", Released>,
]>,
Documentation<HasDocumentation>;

def FixedAddressDereferenceChecker
: Checker<"FixedAddressDereference">,
Expand Down
Loading
Loading