Skip to content

[LLVM][MC][CodeEmitterGen] Reduce various InstBits table sizes #156213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

[LLVM][MC][CodeEmitterGen] Reduce various InstBits table sizes #156213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f78f8b6
[LLVM][MC][CodeEmitterGen] Reduce various `InstBits` table sizes
jurahul Aug 30, 2025
a85d4ce
Revert ReportError refactor
jurahul Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 26 additions & 20 deletions llvm/test/TableGen/HwModeEncodeAPInt.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,32 +114,38 @@ def unrelated: Instruction {
// For 'baz' we only assigned ModeB for it, so it will be presented
// as '0' in the tables of ModeA, ModeC and Default Mode.
// ENCODER-LABEL: static const uint64_t InstBits[] = {
// ENCODER: UINT64_C(2), UINT64_C(0), // bar
// ENCODER: UINT64_C(0), UINT64_C(0), // baz
// ENCODER: UINT64_C(8), UINT64_C(0), // foo
// ENCODER: UINT64_C(2), UINT64_C(0), // unrelated
// ENCODER-NEXT: UINT64_C(2), UINT64_C(0), // bar
// ENCODER-NEXT: UINT64_C(0), UINT64_C(0), // baz
// ENCODER-NEXT: UINT64_C(8), UINT64_C(0), // foo
// ENCODER-NEXT: UINT64_C(2), UINT64_C(0), // unrelated
// ENCODER-NEXT: };
// ENCODER-LABEL: static const uint64_t InstBits_ModeA[] = {
// ENCODER: UINT64_C(2), UINT64_C(0), // bar
// ENCODER: UINT64_C(0), UINT64_C(0), // baz
// ENCODER: UINT64_C(12), UINT64_C(0), // foo
// ENCODER: UINT64_C(2), UINT64_C(0), // unrelated
// ENCODER-NEXT: UINT64_C(2), UINT64_C(0), // bar
// ENCODER-NEXT: UINT64_C(0), UINT64_C(0), // baz
// ENCODER-NEXT: UINT64_C(12), UINT64_C(0), // foo
// ENCODER-NEXT: UINT64_C(2), UINT64_C(0), // unrelated
// ENCODER-NEXT: };
// ENCODER-LABEL: static const uint64_t InstBits_ModeB[] = {
// ENCODER: UINT64_C(2), UINT64_C(0), // bar
// ENCODER: UINT64_C(12), UINT64_C(0), // baz
// ENCODER: UINT64_C(0), UINT64_C(211106232532992), // foo
// ENCODER: UINT64_C(2), UINT64_C(0), // unrelated
// ENCODER-NEXT: UINT64_C(2), UINT64_C(0), // bar
// ENCODER-NEXT: UINT64_C(12), UINT64_C(0), // baz
// ENCODER-NEXT: UINT64_C(0), UINT64_C(211106232532992), // foo
// ENCODER-NEXT: UINT64_C(2), UINT64_C(0), // unrelated
// ENCODER-NEXT: };
// ENCODER-LABEL: static const uint64_t InstBits_ModeC[] = {
// ENCODER: UINT64_C(2), UINT64_C(0), // bar
// ENCODER: UINT64_C(0), UINT64_C(0), // baz
// ENCODER: UINT64_C(12582915), UINT64_C(0), // foo
// ENCODER: UINT64_C(2), UINT64_C(0), // unrelated

// ENCODER-NEXT: UINT64_C(2), UINT64_C(0), // bar
// ENCODER-NEXT: UINT64_C(0), UINT64_C(0), // baz
// ENCODER-NEXT: UINT64_C(12582915), UINT64_C(0), // foo
// ENCODER-NEXT: UINT64_C(2), UINT64_C(0), // unrelated
// ENCODER-NEXT: };

// ENCODER: const uint64_t *InstBitsByHw;
// ENCODER: constexpr unsigned FirstSupportedOpcode
// ENCODER: const unsigned opcode = MI.getOpcode();
// ENCODER: if (opcode < FirstSupportedOpcode)
// ENCODER: unsigned TableIndex = opcode - FirstSupportedOpcode
// ENCODER: if (Scratch.getBitWidth() != 128)
// ENCODER: Scratch = Scratch.zext(128);
// ENCODER: Inst = APInt(128, ArrayRef(InstBits + opcode * 2, 2));
// ENCODER: Inst = APInt(128, ArrayRef(InstBits + TableIndex * 2, 2));
// ENCODER: APInt &Value = Inst;
// ENCODER: APInt &op = Scratch;
// ENCODER: switch (opcode) {
Expand All @@ -155,7 +161,7 @@ def unrelated: Instruction {
// ENCODER: case 2: InstBitsByHw = InstBits_ModeB; break;
// ENCODER: case 3: InstBitsByHw = InstBits_ModeC; break;
// ENCODER: };
// ENCODER: Inst = APInt(128, ArrayRef(InstBitsByHw + opcode * 2, 2));
// ENCODER: Inst = APInt(128, ArrayRef(InstBitsByHw + TableIndex * 2, 2));
// ENCODER: Value = Inst;
// ENCODER: switch (HwMode) {
// ENCODER: default: llvm_unreachable("Unhandled HwMode");
Expand Down Expand Up @@ -189,7 +195,7 @@ def unrelated: Instruction {
// ENCODER: default: llvm_unreachable("Unknown hardware mode!"); break;
// ENCODER: case 2: InstBitsByHw = InstBits_ModeB; break;
// ENCODER: };
// ENCODER: Inst = APInt(128, ArrayRef(InstBitsByHw + opcode * 2, 2));
// ENCODER: Inst = APInt(128, ArrayRef(InstBitsByHw + TableIndex * 2, 2));
// ENCODER: Value = Inst;
// ENCODER: switch (HwMode) {
// ENCODER: default: llvm_unreachable("Unhandled HwMode");
Expand Down
40 changes: 22 additions & 18 deletions llvm/test/TableGen/HwModeEncodeDecode3.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,25 +189,29 @@ def unrelated: Instruction {
// For 'baz' we only assigned ModeB for it, so it will be presented
// as '0' in the tables of ModeA, ModeC and Default Mode.
// ENCODER-LABEL: static const uint64_t InstBits[] = {
// ENCODER: UINT64_C(2), // bar
// ENCODER: UINT64_C(0), // baz
// ENCODER: UINT64_C(8), // foo
// ENCODER: UINT64_C(2), // unrelated
// ENCODER-NEXT: UINT64_C(2), // bar
// ENCODER-NEXT: UINT64_C(0), // baz
// ENCODER-NEXT: UINT64_C(8), // foo
// ENCODER-NEXT: UINT64_C(2), // unrelated
// ENCODER-NEXT: };
// ENCODER-LABEL: static const uint64_t InstBits_ModeA[] = {
// ENCODER: UINT64_C(2), // bar
// ENCODER: UINT64_C(0), // baz
// ENCODER: UINT64_C(12), // foo
// ENCODER: UINT64_C(2), // unrelated
// ENCODER-NEXT: UINT64_C(2), // bar
// ENCODER-NEXT: UINT64_C(0), // baz
// ENCODER-NEXT: UINT64_C(12), // foo
// ENCODER-NEXT: UINT64_C(2), // unrelated
// ENCODER-NEXT: };
// ENCODER-LABEL: static const uint64_t InstBits_ModeB[] = {
// ENCODER: UINT64_C(2), // bar
// ENCODER: UINT64_C(12), // baz
// ENCODER: UINT64_C(3), // foo
// ENCODER: UINT64_C(2), // unrelated
// ENCODER-NEXT: UINT64_C(2), // bar
// ENCODER-NEXT: UINT64_C(12), // baz
// ENCODER-NEXT: UINT64_C(3), // foo
// ENCODER-NEXT: UINT64_C(2), // unrelated
// ENCODER-NEXT: };
// ENCODER-LABEL: static const uint64_t InstBits_ModeC[] = {
// ENCODER: UINT64_C(2), // bar
// ENCODER: UINT64_C(0), // baz
// ENCODER: UINT64_C(12582915), // foo
// ENCODER: UINT64_C(2), // unrelated
// ENCODER-NEXT: UINT64_C(2), // bar
// ENCODER-NEXT: UINT64_C(0), // baz
// ENCODER-NEXT: UINT64_C(12582915), // foo
// ENCODER-NEXT: UINT64_C(2), // unrelated
// ENCODER-NEXT: };

// ENCODER-LABEL: case ::bar:
// ENCODER-LABEL: case ::unrelated:
Expand All @@ -221,7 +225,7 @@ def unrelated: Instruction {
// ENCODER: case 2: InstBitsByHw = InstBits_ModeB; break;
// ENCODER: case 3: InstBitsByHw = InstBits_ModeC; break;
// ENCODER: };
// ENCODER: Value = InstBitsByHw[opcode];
// ENCODER: Value = InstBitsByHw[TableIndex];
// ENCODER: switch (HwMode) {
// ENCODER: default: llvm_unreachable("Unhandled HwMode");
// ENCODER: case 0: {
Expand Down Expand Up @@ -256,7 +260,7 @@ def unrelated: Instruction {
// ENCODER: default: llvm_unreachable("Unknown hardware mode!"); break;
// ENCODER: case 2: InstBitsByHw = InstBits_ModeB; break;
// ENCODER: };
// ENCODER: Value = InstBitsByHw[opcode];
// ENCODER: Value = InstBitsByHw[TableIndex];
// ENCODER: switch (HwMode) {
// ENCODER: default: llvm_unreachable("Unhandled HwMode");
// ENCODER: case 2: {
Expand Down
Loading