diff --git a/lld/MachO/Driver.cpp b/lld/MachO/Driver.cpp index bcba759b2bbee..3db638e1ead96 100644 --- a/lld/MachO/Driver.cpp +++ b/lld/MachO/Driver.cpp @@ -1833,11 +1833,12 @@ bool link(ArrayRef argsArr, llvm::raw_ostream &stdoutOS, if (auto *arg = args.getLastArg(OPT_read_workers)) { StringRef v(arg->getValue()); - unsigned threads = 0; - if (!llvm::to_integer(v, threads, 0) || threads < 0) - error(arg->getSpelling() + ": expected a positive integer, but got '" + - arg->getValue() + "'"); - config->readWorkers = threads; + unsigned workers = 0; + if (!llvm::to_integer(v, workers, 0)) + error(arg->getSpelling() + + ": expected a non-negative integer, but got '" + arg->getValue() + + "'"); + config->readWorkers = workers; } if (auto *arg = args.getLastArg(OPT_threads_eq)) { StringRef v(arg->getValue()); diff --git a/lld/test/MachO/read-workers.s b/lld/test/MachO/read-workers.s new file mode 100644 index 0000000000000..6f0ea4d894408 --- /dev/null +++ b/lld/test/MachO/read-workers.s @@ -0,0 +1,16 @@ +# REQUIRES: x86 +# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t.o + +## A non-negative integer is allowed. +# RUN: %lld --read-workers=0 %t.o -o /dev/null +# RUN: %lld --read-workers=1 %t.o -o /dev/null +# RUN: %lld --read-workers=2 %t.o -o /dev/null + +# RUN: not %lld --read-workers=all %t.o -o /dev/null 2>&1 | FileCheck %s -DN=all +# RUN: not %lld --read-workers=-1 %t.o -o /dev/null 2>&1 | FileCheck %s -DN=-1 + +# CHECK: error: --read-workers=: expected a non-negative integer, but got '[[N]]' + +.globl _main +_main: + ret