Skip to content

[mlir][spirv] Check variable for null before dereferencing #157457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

[mlir][spirv] Check variable for null before dereferencing #157457

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b58e77
[mlir] Check variable for null before dereferencing in Dialect/SPIRV/IR
apach301 Sep 8, 2025
b1caf4d
Change nullptr checks into assertion
apach301 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,9 +727,9 @@ void mlir::spirv::ConstantOp::getAsmResultNames(
return setNameFn(getResult(), (intCst.getInt() ? "true" : "false"));
}

if (intTy.isSignless()) {
if (intTy && intTy.isSignless()) {
specialName << intCst.getInt();
} else if (intTy.isUnsigned()) {
} else if (intTy && intTy.isUnsigned()) {
specialName << intCst.getUInt();
} else {
specialName << intCst.getSInt();
Expand Down
Loading