Skip to content

Conversation

@kparzysz
Copy link
Contributor

No description provided.

@kparzysz kparzysz merged commit 0efa75d into llvm:main Sep 10, 2025
8 of 9 checks passed
@kparzysz kparzysz deleted the users/kparzysz/fix-details branch September 10, 2025 23:54
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:semantics labels Sep 11, 2025
@llvmbot
Copy link
Member

llvmbot commented Sep 11, 2025

@llvm/pr-subscribers-flang-semantics

Author: Krzysztof Parzyszek (kparzysz)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/157971.diff

1 Files Affected:

  • (modified) flang/lib/Semantics/symbol.cpp (+2-2)
diff --git a/flang/lib/Semantics/symbol.cpp b/flang/lib/Semantics/symbol.cpp
index ea7eeac80a2d9..6152f61fafd7f 100644
--- a/flang/lib/Semantics/symbol.cpp
+++ b/flang/lib/Semantics/symbol.cpp
@@ -332,7 +332,7 @@ bool Symbol::CanReplaceDetails(const Details &details) const {
             [&](const ObjectEntityDetails &) { return has<EntityDetails>(); },
             [&](const ProcEntityDetails &x) { return has<EntityDetails>(); },
             [&](const SubprogramDetails &) {
-              if (const auto *oldProc{detailsIf<ProcEntityDetails>()}) {
+              if (const auto *oldProc{this->detailsIf<ProcEntityDetails>()}) {
                 // Can replace bare "EXTERNAL dummy" with explicit INTERFACE
                 return oldProc->isDummy() && !oldProc->procInterface() &&
                     attrs().test(Attr::EXTERNAL) && !test(Flag::Function) &&
@@ -345,7 +345,7 @@ bool Symbol::CanReplaceDetails(const Details &details) const {
               return derived && derived->isForwardReferenced();
             },
             [&](const UseDetails &x) {
-              const auto *use{detailsIf<UseDetails>()};
+              const auto *use{this->detailsIf<UseDetails>()};
               return use && use->symbol() == x.symbol();
             },
             [&](const HostAssocDetails &) { return has<HostAssocDetails>(); },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:semantics flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants