[Github] Use standard checkout for ABI test workflows #158468
Conversation
These workflows are currently using a custom checkout action in llvm/actions. This does the same thing as actions/checkout, but incurs a maintenance cost that we have not really been paying. Switch over to the Github supported workflow so someone else is paying the maintenance cost.
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThese workflows are currently using a custom checkout action in llvm/actions. This does the same thing as actions/checkout, but incurs a maintenance cost that we have not really been paying. Switch over to the Github supported workflow so someone else is paying the maintenance cost. Full diff: https://github.com/llvm/llvm-project/pull/158468.diff 2 Files Affected:
diff --git a/.github/workflows/libclang-abi-tests.yml b/.github/workflows/libclang-abi-tests.yml
index 3836cc56a7c22..53da0d51f5081 100644
--- a/.github/workflows/libclang-abi-tests.yml
+++ b/.github/workflows/libclang-abi-tests.yml
@@ -113,10 +113,10 @@ jobs:
./configure
sudo make install
- name: Download source code
- uses: llvm/actions/get-llvm-project-src@main
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
ref: ${{ matrix.ref }}
- repo: ${{ matrix.repo }}
+ repository: ${{ matrix.repo }}
- name: Configure
run: |
mkdir install
diff --git a/.github/workflows/llvm-tests.yml b/.github/workflows/llvm-tests.yml
index 52b486e7e62fc..d941b969183fa 100644
--- a/.github/workflows/llvm-tests.yml
+++ b/.github/workflows/llvm-tests.yml
@@ -101,10 +101,10 @@ jobs:
./configure
sudo make install
- name: Download source code
- uses: llvm/actions/get-llvm-project-src@main
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
ref: ${{ matrix.ref }}
- repo: ${{ matrix.repo }}
+ repository: ${{ matrix.repo }}
- name: Configure
run: |
mkdir install
|
After llvm/llvm-project#158468 there are no remaining uses of this in the monorepo (except for the existing ones on the release branch). Because of that, we can remove this.
|
@boomanaiden154 Do you happen to know why these actions used custom thing? |
I'm not sure. Looking through the git history is difficult because they got added in https://reviews.llvm.org/D129526, but I can't find anything from before that. llvm/actions@55d8448 is also pretty vague. It has support for downloading release source tarballs, so I'm wondering if it had to do with the split release/main repo, or maybe missing features in actions/checkout. |
|
Maybe @tstellar knows :) |
|
I think I did it, because it was faster than the checkout action for when you didn't care about the git history. I'm fine with dropping it, though. No that we have composite actions, I think we can probably drop or replace everything from the actions repo. |
Yeah, that would enable some nice cleanup. |
These workflows are currently using a custom checkout action in llvm/actions. This does the same thing as actions/checkout, but incurs a maintenance cost that we have not really been paying. Switch over to the Github supported workflow so someone else is paying the maintenance cost.