Skip to content

Conversation

@makslevental
Copy link
Contributor

@makslevental makslevental commented Sep 16, 2025

lit complains if these aren't found (even if they're not used by a test...) so make sure to include all of them in MLIR_PYTHON_TEST_DEPENDS.

@llvmbot
Copy link
Member

llvmbot commented Sep 16, 2025

@llvm/pr-subscribers-mlir

Author: Maksim Levental (makslevental)

Changes

lit complains if these aren't found (even if they're not used by a test...) so make sure to include all of them in MLIR_PYTHON_TEST_DEPENDS.


Full diff: https://github.com/llvm/llvm-project/pull/159124.diff

1 Files Affected:

  • (modified) mlir/test/python/CMakeLists.txt (+1-1)
diff --git a/mlir/test/python/CMakeLists.txt b/mlir/test/python/CMakeLists.txt
index d68f3ff82e883..e1e82ef367b1e 100644
--- a/mlir/test/python/CMakeLists.txt
+++ b/mlir/test/python/CMakeLists.txt
@@ -13,7 +13,7 @@ add_subdirectory(lib)
 
 set(MLIR_PYTHON_TEST_DEPENDS MLIRPythonModules)
 if(NOT MLIR_STANDALONE_BUILD)
-  list(APPEND MLIR_PYTHON_TEST_DEPENDS FileCheck count)
+  list(APPEND MLIR_PYTHON_TEST_DEPENDS FileCheck count not)
 endif()
 add_lit_testsuite(check-mlir-python "Running the MLIR Python regression tests"
   ${CMAKE_CURRENT_BINARY_DIR}

@makslevental makslevental changed the title [MLIR][Python] add not to MLIR_PYTHON_TEST_DEPENDS [MLIR][Python] add not to MLIR_PYTHON_TEST_DEPENDS Sep 16, 2025
@makslevental makslevental merged commit d0c0986 into main Sep 16, 2025
11 checks passed
@makslevental makslevental deleted the users/makslevental/fix-python-test-2 branch September 16, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants