diff --git a/mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp b/mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp index b99a8a3fe17b1..6ad631f1eec7a 100644 --- a/mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp +++ b/mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp @@ -232,7 +232,7 @@ struct ElementwiseArithOpPattern final : OpConversionPattern { /// Converts composite arith.constant operation to spirv.Constant. struct ConstantCompositeOpPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::ConstantOp constOp, OpAdaptor adaptor, @@ -357,7 +357,7 @@ struct ConstantCompositeOpPattern final /// Converts scalar arith.constant operation to spirv.Constant. struct ConstantScalarOpPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::ConstantOp constOp, OpAdaptor adaptor, @@ -467,7 +467,7 @@ static Value emulateSignedRemainder(Location loc, Value lhs, Value rhs, /// This cannot be merged into the template unary/binary pattern due to Vulkan /// restrictions over spirv.SRem and spirv.SMod. struct RemSIOpGLPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::RemSIOp op, OpAdaptor adaptor, @@ -483,7 +483,7 @@ struct RemSIOpGLPattern final : public OpConversionPattern { /// Converts arith.remsi to OpenCL SPIR-V ops. struct RemSIOpCLPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::RemSIOp op, OpAdaptor adaptor, @@ -534,7 +534,7 @@ struct BitwiseOpPattern final : public OpConversionPattern { /// Converts arith.xori to SPIR-V operations. struct XOrIOpLogicalPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::XOrIOp op, OpAdaptor adaptor, @@ -558,7 +558,7 @@ struct XOrIOpLogicalPattern final : public OpConversionPattern { /// Converts arith.xori to SPIR-V operations if the type of source is i1 or /// vector of i1. struct XOrIOpBooleanPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::XOrIOp op, OpAdaptor adaptor, @@ -585,7 +585,7 @@ struct XOrIOpBooleanPattern final : public OpConversionPattern { /// Converts arith.uitofp to spirv.Select if the type of source is i1 or vector /// of i1. struct UIToFPI1Pattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::UIToFPOp op, OpAdaptor adaptor, @@ -614,7 +614,7 @@ struct UIToFPI1Pattern final : public OpConversionPattern { /// Converts arith.index_cast to spirv.INotEqual if the target type is i1. struct IndexCastIndexI1Pattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::IndexCastOp op, OpAdaptor adaptor, @@ -638,7 +638,7 @@ struct IndexCastIndexI1Pattern final /// Converts arith.index_cast to spirv.Select if the source type is i1. struct IndexCastI1IndexPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::IndexCastOp op, OpAdaptor adaptor, @@ -666,7 +666,7 @@ struct IndexCastI1IndexPattern final /// Converts arith.extsi to spirv.Select if the type of source is i1 or vector /// of i1. struct ExtSII1Pattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::ExtSIOp op, OpAdaptor adaptor, @@ -707,7 +707,7 @@ struct ExtSII1Pattern final : public OpConversionPattern { /// Converts arith.extsi to spirv.Select if the type of source is neither i1 nor /// vector of i1. struct ExtSIPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::ExtSIOp op, OpAdaptor adaptor, @@ -758,7 +758,7 @@ struct ExtSIPattern final : public OpConversionPattern { /// Converts arith.extui to spirv.Select if the type of source is i1 or vector /// of i1. struct ExtUII1Pattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::ExtUIOp op, OpAdaptor adaptor, @@ -783,7 +783,7 @@ struct ExtUII1Pattern final : public OpConversionPattern { /// Converts arith.extui for cases where the type of source is neither i1 nor /// vector of i1. struct ExtUIPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::ExtUIOp op, OpAdaptor adaptor, @@ -823,7 +823,7 @@ struct ExtUIPattern final : public OpConversionPattern { /// Converts arith.trunci to spirv.Select if the type of result is i1 or vector /// of i1. struct TruncII1Pattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::TruncIOp op, OpAdaptor adaptor, @@ -853,7 +853,7 @@ struct TruncII1Pattern final : public OpConversionPattern { /// Converts arith.trunci for cases where the type of result is neither i1 /// nor vector of i1. struct TruncIPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::TruncIOp op, OpAdaptor adaptor, @@ -963,7 +963,7 @@ struct TypeCastingOpPattern final : public OpConversionPattern { /// Converts integer compare operation on i1 type operands to SPIR-V ops. class CmpIOpBooleanPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::CmpIOp op, OpAdaptor adaptor, @@ -1014,7 +1014,7 @@ class CmpIOpBooleanPattern final : public OpConversionPattern { /// Converts integer compare operation to SPIR-V ops. class CmpIOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::CmpIOp op, OpAdaptor adaptor, @@ -1063,7 +1063,7 @@ class CmpIOpPattern final : public OpConversionPattern { /// Converts floating-point comparison operations to SPIR-V ops. class CmpFOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::CmpFOp op, OpAdaptor adaptor, @@ -1103,7 +1103,7 @@ class CmpFOpPattern final : public OpConversionPattern { /// Kernel capability. class CmpFOpNanKernelPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::CmpFOp op, OpAdaptor adaptor, @@ -1128,7 +1128,7 @@ class CmpFOpNanKernelPattern final : public OpConversionPattern { /// require additional capability. class CmpFOpNanNonePattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::CmpFOp op, OpAdaptor adaptor, @@ -1170,7 +1170,7 @@ class CmpFOpNanNonePattern final : public OpConversionPattern { class AddUIExtendedOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::AddUIExtendedOp op, OpAdaptor adaptor, ConversionPatternRewriter &rewriter) const override { @@ -1226,7 +1226,7 @@ class MulIExtendedOpPattern final : public OpConversionPattern { /// Converts arith.select to spirv.Select. class SelectOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(arith::SelectOp op, OpAdaptor adaptor, ConversionPatternRewriter &rewriter) const override { diff --git a/mlir/lib/Conversion/ComplexToSPIRV/ComplexToSPIRV.cpp b/mlir/lib/Conversion/ComplexToSPIRV/ComplexToSPIRV.cpp index 4225f815ab69d..a2a2faf8ea570 100644 --- a/mlir/lib/Conversion/ComplexToSPIRV/ComplexToSPIRV.cpp +++ b/mlir/lib/Conversion/ComplexToSPIRV/ComplexToSPIRV.cpp @@ -27,7 +27,7 @@ using namespace mlir; namespace { struct ConstantOpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(complex::ConstantOp constOp, OpAdaptor adaptor, @@ -46,7 +46,7 @@ struct ConstantOpPattern final : OpConversionPattern { }; struct CreateOpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(complex::CreateOp createOp, OpAdaptor adaptor, @@ -63,7 +63,7 @@ struct CreateOpPattern final : OpConversionPattern { }; struct ReOpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(complex::ReOp reOp, OpAdaptor adaptor, @@ -79,7 +79,7 @@ struct ReOpPattern final : OpConversionPattern { }; struct ImOpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(complex::ImOp imOp, OpAdaptor adaptor, diff --git a/mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRV.cpp b/mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRV.cpp index caaffc5a33155..7fa6cb4448f80 100644 --- a/mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRV.cpp +++ b/mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRV.cpp @@ -62,7 +62,7 @@ static LogicalResult legalizeBlockArguments(Block &block, Operation *op, namespace { /// Converts cf.br to spirv.Branch. struct BranchOpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(cf::BranchOp op, OpAdaptor adaptor, @@ -79,7 +79,7 @@ struct BranchOpPattern final : OpConversionPattern { /// Converts cf.cond_br to spirv.BranchConditional. struct CondBranchOpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(cf::CondBranchOp op, OpAdaptor adaptor, diff --git a/mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRV.cpp b/mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRV.cpp index 7cc9680236b01..7ceab394a67ff 100644 --- a/mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRV.cpp +++ b/mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRV.cpp @@ -34,7 +34,7 @@ namespace { /// Converts func.return to spirv.Return. class ReturnOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(func::ReturnOp returnOp, OpAdaptor adaptor, @@ -55,7 +55,7 @@ class ReturnOpPattern final : public OpConversionPattern { /// Converts func.call to spirv.FunctionCall. class CallOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(func::CallOp callOp, OpAdaptor adaptor, diff --git a/mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp b/mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp index 3545acb20212d..c33a903d03393 100644 --- a/mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp +++ b/mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp @@ -69,7 +69,7 @@ class WorkGroupSizeConversion : public OpConversionPattern { /// Pattern to convert a kernel function in GPU dialect within a spirv.module. class GPUFuncOpConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::GPUFuncOp funcOp, OpAdaptor adaptor, @@ -82,7 +82,7 @@ class GPUFuncOpConversion final : public OpConversionPattern { /// Pattern to convert a gpu.module to a spirv.module. class GPUModuleConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::GPUModuleOp moduleOp, OpAdaptor adaptor, @@ -93,7 +93,7 @@ class GPUModuleConversion final : public OpConversionPattern { // TODO: This can go to DRR when GPU return has operands. class GPUReturnOpConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::ReturnOp returnOp, OpAdaptor adaptor, @@ -103,7 +103,7 @@ class GPUReturnOpConversion final : public OpConversionPattern { /// Pattern to convert a gpu.barrier op into a spirv.ControlBarrier op. class GPUBarrierConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::BarrierOp barrierOp, OpAdaptor adaptor, @@ -113,7 +113,7 @@ class GPUBarrierConversion final : public OpConversionPattern { /// Pattern to convert a gpu.shuffle op into a spirv.GroupNonUniformShuffle op. class GPUShuffleConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::ShuffleOp shuffleOp, OpAdaptor adaptor, @@ -123,7 +123,7 @@ class GPUShuffleConversion final : public OpConversionPattern { /// Pattern to convert a gpu.rotate op into a spirv.GroupNonUniformRotateKHROp. class GPURotateConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::RotateOp rotateOp, OpAdaptor adaptor, @@ -132,7 +132,7 @@ class GPURotateConversion final : public OpConversionPattern { class GPUPrintfConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::PrintfOp gpuPrintfOp, OpAdaptor adaptor, @@ -653,7 +653,7 @@ createGroupReduceOp(OpBuilder &builder, Location loc, Value arg, class GPUAllReduceConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::AllReduceOp op, OpAdaptor adaptor, @@ -680,7 +680,7 @@ class GPUAllReduceConversion final class GPUSubgroupReduceConversion final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupReduceOp op, OpAdaptor adaptor, diff --git a/mlir/lib/Conversion/GPUToSPIRV/WmmaOpsToSPIRV.cpp b/mlir/lib/Conversion/GPUToSPIRV/WmmaOpsToSPIRV.cpp index c1b09f18af560..c4d9310874cc4 100644 --- a/mlir/lib/Conversion/GPUToSPIRV/WmmaOpsToSPIRV.cpp +++ b/mlir/lib/Conversion/GPUToSPIRV/WmmaOpsToSPIRV.cpp @@ -96,7 +96,7 @@ namespace { /// matrix ops. struct WmmaConstantOpToSPIRVLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupMmaConstantMatrixOp op, OpAdaptor adaptor, @@ -115,7 +115,7 @@ struct WmmaConstantOpToSPIRVLowering final /// matrix ops. struct WmmaExtractOpToSPIRVLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupMmaExtractThreadLocalOp op, OpAdaptor adaptor, @@ -147,7 +147,7 @@ struct WmmaExtractOpToSPIRVLowering final /// matrix ops. struct WmmaInsertOpToSPIRVLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupMmaInsertThreadLocalOp op, OpAdaptor adaptor, @@ -177,7 +177,7 @@ struct WmmaInsertOpToSPIRVLowering final /// the default case. struct WmmaElementwiseOpToSPIRVDefaultLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupMmaElementwiseOp op, OpAdaptor adaptor, @@ -201,7 +201,7 @@ struct WmmaElementwiseOpToSPIRVDefaultLowering final /// matrix times scalar case. struct WmmaElementwiseOpToSPIRVScalarMulLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupMmaElementwiseOp op, OpAdaptor adaptor, @@ -265,7 +265,7 @@ namespace { /// dialect. struct WmmaLoadOpToSPIRVLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupMmaLoadMatrixOp op, OpAdaptor adaptor, @@ -303,7 +303,7 @@ struct WmmaLoadOpToSPIRVLowering final /// dialect. struct WmmaStoreOpToSPIRVLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupMmaStoreMatrixOp op, OpAdaptor adaptor, @@ -335,7 +335,7 @@ struct WmmaStoreOpToSPIRVLowering final /// dialect. struct WmmaMmaOpToSPIRVLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(gpu::SubgroupMmaComputeOp subgroupMmaComputeOp, diff --git a/mlir/lib/Conversion/IndexToSPIRV/IndexToSPIRV.cpp b/mlir/lib/Conversion/IndexToSPIRV/IndexToSPIRV.cpp index 36cfe9dd6e2db..bc2f2f2a3fe93 100644 --- a/mlir/lib/Conversion/IndexToSPIRV/IndexToSPIRV.cpp +++ b/mlir/lib/Conversion/IndexToSPIRV/IndexToSPIRV.cpp @@ -59,7 +59,7 @@ using ConvertIndexXor = spirv::ElementwiseOpPattern; // Converts index.bool.constant operation to spirv.Constant. struct ConvertIndexConstantBoolOpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(BoolConstantOp op, BoolConstantOpAdaptor adaptor, @@ -77,7 +77,7 @@ struct ConvertIndexConstantBoolOpPattern final // Converts index.constant op to spirv.Constant. Will truncate from i64 to i32 // when required. struct ConvertIndexConstantOpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(ConstantOp op, ConstantOpAdaptor adaptor, @@ -100,7 +100,7 @@ struct ConvertIndexConstantOpPattern final : OpConversionPattern { /// `n*m > 0 ? (n+x)/m + 1 : -(-n/m)`. Formula taken from the equivalent /// conversion in IndexToLLVM. struct ConvertIndexCeilDivSPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(CeilDivSOp op, CeilDivSOpAdaptor adaptor, @@ -150,7 +150,7 @@ struct ConvertIndexCeilDivSPattern final : OpConversionPattern { /// Convert `ceildivu(n, m)` into `n == 0 ? 0 : (n-1)/m + 1`. Formula taken /// from the equivalent conversion in IndexToLLVM. struct ConvertIndexCeilDivUPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(CeilDivUOp op, CeilDivUOpAdaptor adaptor, @@ -186,7 +186,7 @@ struct ConvertIndexCeilDivUPattern final : OpConversionPattern { /// `n*m < 0 ? -1 - (x-n)/m : n/m`. Formula taken from the equivalent conversion /// in IndexToLLVM. struct ConvertIndexFloorDivSPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(FloorDivSOp op, FloorDivSOpAdaptor adaptor, @@ -282,7 +282,7 @@ static LogicalResult rewriteCmpOp(CmpOp op, CmpOpAdaptor adaptor, } struct ConvertIndexCmpPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(CmpOp op, CmpOpAdaptor adaptor, @@ -320,7 +320,7 @@ struct ConvertIndexCmpPattern final : OpConversionPattern { /// Lower `index.sizeof` to a constant with the value of the index bitwidth. struct ConvertIndexSizeOf final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(SizeOfOp op, SizeOfOpAdaptor adaptor, diff --git a/mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp b/mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp index 1787e0a44f8fd..f0d8b78058607 100644 --- a/mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp +++ b/mlir/lib/Conversion/MathToSPIRV/MathToSPIRV.cpp @@ -117,7 +117,7 @@ struct CheckedElementwiseOpPattern final /// Converts math.copysign to SPIR-V ops. struct CopySignPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(math::CopySignOp copySignOp, OpAdaptor adaptor, @@ -188,7 +188,7 @@ struct CopySignPattern final : public OpConversionPattern { /// it. struct CountLeadingZerosPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(math::CountLeadingZerosOp countOp, OpAdaptor adaptor, @@ -239,7 +239,7 @@ struct CountLeadingZerosPattern final /// these operations. template struct ExpM1OpPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(math::ExpM1Op operation, OpAdaptor adaptor, @@ -267,7 +267,7 @@ struct ExpM1OpPattern final : public OpConversionPattern { /// these operations. template struct Log1pOpPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(math::Log1pOp operation, OpAdaptor adaptor, @@ -351,7 +351,7 @@ struct Log2Log10OpPattern final : public OpConversionPattern { /// Converts math.powf to SPIRV-Ops. struct PowFOpPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(math::PowFOp powfOp, OpAdaptor adaptor, @@ -440,7 +440,7 @@ struct PowFOpPattern final : public OpConversionPattern { /// Converts math.round to GLSL SPIRV extended ops. struct RoundOpPattern final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(math::RoundOp roundOp, OpAdaptor adaptor, diff --git a/mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRV.cpp b/mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRV.cpp index 2e00b42f4a56d..49d06497dbeea 100644 --- a/mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRV.cpp +++ b/mlir/lib/Conversion/MemRefToSPIRV/MemRefToSPIRV.cpp @@ -183,7 +183,7 @@ namespace { /// Converts memref.alloca to SPIR-V Function variables. class AllocaOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::AllocaOp allocaOp, OpAdaptor adaptor, @@ -196,7 +196,7 @@ class AllocaOpPattern final : public OpConversionPattern { /// wil ladd global variables into the spirv.module. class AllocOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::AllocOp operation, OpAdaptor adaptor, @@ -207,7 +207,7 @@ class AllocOpPattern final : public OpConversionPattern { class AtomicRMWOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::AtomicRMWOp atomicOp, OpAdaptor adaptor, @@ -218,7 +218,7 @@ class AtomicRMWOpPattern final /// removes deallocation if the memory space is workgroup memory. class DeallocOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::DeallocOp operation, OpAdaptor adaptor, @@ -228,7 +228,7 @@ class DeallocOpPattern final : public OpConversionPattern { /// Converts memref.load to spirv.Load + spirv.AccessChain on integers. class IntLoadOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::LoadOp loadOp, OpAdaptor adaptor, @@ -238,7 +238,7 @@ class IntLoadOpPattern final : public OpConversionPattern { /// Converts memref.load to spirv.Load + spirv.AccessChain. class LoadOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::LoadOp loadOp, OpAdaptor adaptor, @@ -248,7 +248,7 @@ class LoadOpPattern final : public OpConversionPattern { /// Converts memref.load to spirv.Image + spirv.ImageFetch class ImageLoadOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::LoadOp loadOp, OpAdaptor adaptor, @@ -258,7 +258,7 @@ class ImageLoadOpPattern final : public OpConversionPattern { /// Converts memref.store to spirv.Store on integers. class IntStoreOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::StoreOp storeOp, OpAdaptor adaptor, @@ -269,7 +269,7 @@ class IntStoreOpPattern final : public OpConversionPattern { class MemorySpaceCastOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::MemorySpaceCastOp addrCastOp, OpAdaptor adaptor, @@ -279,7 +279,7 @@ class MemorySpaceCastOpPattern final /// Converts memref.store to spirv.Store. class StoreOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::StoreOp storeOp, OpAdaptor adaptor, @@ -289,7 +289,7 @@ class StoreOpPattern final : public OpConversionPattern { class ReinterpretCastPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::ReinterpretCastOp op, OpAdaptor adaptor, @@ -298,7 +298,7 @@ class ReinterpretCastPattern final class CastPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::CastOp op, OpAdaptor adaptor, @@ -322,7 +322,7 @@ class CastPattern final : public OpConversionPattern { class ExtractAlignedPointerAsIndexOpPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(memref::ExtractAlignedPointerAsIndexOp extractOp, diff --git a/mlir/lib/Conversion/UBToSPIRV/UBToSPIRV.cpp b/mlir/lib/Conversion/UBToSPIRV/UBToSPIRV.cpp index 01c35cba48c49..244d214cba196 100644 --- a/mlir/lib/Conversion/UBToSPIRV/UBToSPIRV.cpp +++ b/mlir/lib/Conversion/UBToSPIRV/UBToSPIRV.cpp @@ -23,7 +23,7 @@ using namespace mlir; namespace { struct PoisonOpLowering final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(ub::PoisonOp op, OpAdaptor, diff --git a/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp b/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp index 1c311d0312aaa..04f56b9691fd1 100644 --- a/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp +++ b/mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp @@ -57,7 +57,7 @@ static int getNumBits(Type type) { namespace { struct VectorShapeCast final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::ShapeCastOp shapeCastOp, OpAdaptor adaptor, @@ -83,7 +83,7 @@ struct VectorShapeCast final : public OpConversionPattern { // `vector.broadcast` to SPIRV via other patterns. struct VectorSplatToBroadcast final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::SplatOp splat, OpAdaptor adaptor, ConversionPatternRewriter &rewriter) const override { @@ -95,7 +95,7 @@ struct VectorSplatToBroadcast final struct VectorBitcastConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::BitCastOp bitcastOp, OpAdaptor adaptor, @@ -128,7 +128,7 @@ struct VectorBitcastConvert final struct VectorBroadcastConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::BroadcastOp castOp, OpAdaptor adaptor, @@ -180,7 +180,7 @@ static Value sanitizeDynamicIndex(ConversionPatternRewriter &rewriter, struct VectorExtractOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::ExtractOp extractOp, OpAdaptor adaptor, @@ -217,7 +217,7 @@ struct VectorExtractOpConvert final struct VectorExtractStridedSliceOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::ExtractStridedSliceOp extractOp, OpAdaptor adaptor, @@ -254,7 +254,7 @@ struct VectorExtractStridedSliceOpConvert final template struct VectorFmaOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::FMAOp fmaOp, OpAdaptor adaptor, @@ -270,7 +270,7 @@ struct VectorFmaOpConvert final : public OpConversionPattern { struct VectorFromElementsOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::FromElementsOp op, OpAdaptor adaptor, @@ -296,7 +296,7 @@ struct VectorFromElementsOpConvert final struct VectorInsertOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::InsertOp insertOp, OpAdaptor adaptor, @@ -337,7 +337,7 @@ struct VectorInsertOpConvert final struct VectorInsertStridedSliceOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::InsertStridedSliceOp insertOp, OpAdaptor adaptor, @@ -419,7 +419,7 @@ FailureOr static getReductionInfo( template struct VectorReductionPattern final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::ReductionOp reduceOp, OpAdaptor adaptor, @@ -476,7 +476,7 @@ struct VectorReductionPattern final : OpConversionPattern { template struct VectorReductionFloatMinMax final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::ReductionOp reduceOp, OpAdaptor adaptor, @@ -516,7 +516,7 @@ struct VectorReductionFloatMinMax final class VectorScalarBroadcastPattern final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::BroadcastOp op, OpAdaptor adaptor, @@ -543,7 +543,7 @@ class VectorScalarBroadcastPattern final struct VectorShuffleOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::ShuffleOp shuffleOp, OpAdaptor adaptor, @@ -609,7 +609,7 @@ struct VectorShuffleOpConvert final struct VectorInterleaveOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::InterleaveOp interleaveOp, OpAdaptor adaptor, @@ -650,7 +650,7 @@ struct VectorInterleaveOpConvert final struct VectorDeinterleaveOpConvert final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::DeinterleaveOp deinterleaveOp, OpAdaptor adaptor, @@ -712,7 +712,7 @@ struct VectorDeinterleaveOpConvert final struct VectorLoadOpConverter final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::LoadOp loadOp, OpAdaptor adaptor, @@ -778,7 +778,7 @@ struct VectorLoadOpConverter final struct VectorStoreOpConverter final : public OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::StoreOp storeOp, OpAdaptor adaptor, @@ -933,7 +933,7 @@ struct VectorReductionToIntDotProd final struct VectorReductionToFPDotProd final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::ReductionOp op, OpAdaptor adaptor, @@ -989,7 +989,7 @@ struct VectorReductionToFPDotProd final }; struct VectorStepOpConvert final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::StepOp stepOp, OpAdaptor adaptor, @@ -1028,7 +1028,7 @@ struct VectorStepOpConvert final : OpConversionPattern { struct VectorToElementOpConvert final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(vector::ToElementsOp toElementsOp, OpAdaptor adaptor, diff --git a/mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.cpp b/mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.cpp index 2bde44baf961e..ccc85368c78a4 100644 --- a/mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.cpp +++ b/mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.cpp @@ -93,7 +93,7 @@ namespace { /// `spirv::AccessChainOp` operation. struct CombineChainedAccessChain final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::AccessChainOp accessChainOp, PatternRewriter &rewriter) const override { @@ -128,7 +128,7 @@ void spirv::AccessChainOp::getCanonicalizationPatterns( // We are required to use CompositeConstructOp to create a constant struct as // they are not yet implemented as constant, hence we can not do so in a fold. struct IAddCarryFold final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::IAddCarryOp op, PatternRewriter &rewriter) const override { @@ -284,7 +284,7 @@ void spirv::SMulExtendedOp::getCanonicalizationPatterns( } struct UMulExtendedOpXOne final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::UMulExtendedOp op, PatternRewriter &rewriter) const override { @@ -326,7 +326,7 @@ void spirv::UMulExtendedOp::getCanonicalizationPatterns( // The transformation is only applied if one divisor is a multiple of the other. struct UModSimplification final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::UModOp umodOp, PatternRewriter &rewriter) const override { @@ -1271,7 +1271,7 @@ namespace { // +-------------+ // struct ConvertSelectionOpToSelect final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::SelectionOp selectionOp, PatternRewriter &rewriter) const override { diff --git a/mlir/lib/Dialect/SPIRV/Transforms/ConvertToReplicatedConstantCompositePass.cpp b/mlir/lib/Dialect/SPIRV/Transforms/ConvertToReplicatedConstantCompositePass.cpp index dbbe23aa08b3c..2f5588c7f8cc7 100644 --- a/mlir/lib/Dialect/SPIRV/Transforms/ConvertToReplicatedConstantCompositePass.cpp +++ b/mlir/lib/Dialect/SPIRV/Transforms/ConvertToReplicatedConstantCompositePass.cpp @@ -64,7 +64,7 @@ getSplatAttrAndNumElements(Attribute valueAttr, Type valueType) { } struct ConstantOpConversion final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::ConstantOp op, PatternRewriter &rewriter) const override { @@ -85,7 +85,7 @@ struct ConstantOpConversion final : OpRewritePattern { struct SpecConstantCompositeOpConversion final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::SpecConstantCompositeOp op, PatternRewriter &rewriter) const override { diff --git a/mlir/lib/Dialect/SPIRV/Transforms/DecorateCompositeTypeLayoutPass.cpp b/mlir/lib/Dialect/SPIRV/Transforms/DecorateCompositeTypeLayoutPass.cpp index 354db6467a582..a517ca946f3a4 100644 --- a/mlir/lib/Dialect/SPIRV/Transforms/DecorateCompositeTypeLayoutPass.cpp +++ b/mlir/lib/Dialect/SPIRV/Transforms/DecorateCompositeTypeLayoutPass.cpp @@ -36,7 +36,7 @@ namespace { class SPIRVGlobalVariableOpLayoutInfoDecoration : public OpRewritePattern { public: - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::GlobalVariableOp op, PatternRewriter &rewriter) const override { @@ -69,7 +69,7 @@ class SPIRVGlobalVariableOpLayoutInfoDecoration class SPIRVAddressOfOpLayoutInfoDecoration : public OpRewritePattern { public: - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::AddressOfOp op, PatternRewriter &rewriter) const override { diff --git a/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp b/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp index 5607a3cd3660f..b262e6b5d7f75 100644 --- a/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp +++ b/mlir/lib/Dialect/SPIRV/Transforms/LowerABIAttributesPass.cpp @@ -244,7 +244,7 @@ namespace { /// Vulkan requires all shader entry points to be of void(void) type. class ProcessInterfaceVarABI final : public OpConversionPattern { public: - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(spirv::FuncOp funcOp, OpAdaptor adaptor, diff --git a/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp b/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp index 49f4ce8de7c76..122f61e0a66ae 100644 --- a/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp +++ b/mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp @@ -984,7 +984,7 @@ getOrInsertPushConstantVariable(Location loc, Block &block, /// A pattern for rewriting function signature to convert arguments of functions /// to be of valid SPIR-V types. struct FuncOpConversion final : OpConversionPattern { - using OpConversionPattern::OpConversionPattern; + using Base::Base; LogicalResult matchAndRewrite(func::FuncOp funcOp, OpAdaptor adaptor, @@ -1036,7 +1036,7 @@ struct FuncOpConversion final : OpConversionPattern { /// A pattern for rewriting function signature to convert vector arguments of /// functions to be of valid types struct FuncOpVectorUnroll final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(func::FuncOp funcOp, PatternRewriter &rewriter) const override { @@ -1192,7 +1192,7 @@ struct FuncOpVectorUnroll final : OpRewritePattern { /// A pattern for rewriting function signature and the return op to convert /// vectors to be of valid types. struct ReturnOpVectorUnroll final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(func::ReturnOp returnOp, PatternRewriter &rewriter) const override { diff --git a/mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp b/mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp index e0900005ea1bb..8b65b88c608bd 100644 --- a/mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp +++ b/mlir/lib/Dialect/SPIRV/Transforms/SPIRVWebGPUTransforms.cpp @@ -168,7 +168,7 @@ using ExpandUMulExtendedPattern = ExpandMulExtendedPattern; struct ExpandAddCarryPattern final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(IAddCarryOp op, PatternRewriter &rewriter) const override { @@ -205,7 +205,7 @@ struct ExpandAddCarryPattern final : OpRewritePattern { }; struct ExpandIsInfPattern final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(IsInfOp op, PatternRewriter &rewriter) const override { @@ -217,7 +217,7 @@ struct ExpandIsInfPattern final : OpRewritePattern { }; struct ExpandIsNanPattern final : OpRewritePattern { - using OpRewritePattern::OpRewritePattern; + using Base::Base; LogicalResult matchAndRewrite(IsNanOp op, PatternRewriter &rewriter) const override {