Skip to content

Conversation

@nico
Copy link
Contributor

@nico nico commented Sep 19, 2025

@llvmbot
Copy link
Member

llvmbot commented Sep 19, 2025

@llvm/pr-subscribers-llvm-binary-utilities

Author: Nico Weber (nico)

Changes

Follow-up to https://reviews.llvm.org/D46527


Full diff: https://github.com/llvm/llvm-project/pull/159826.diff

1 Files Affected:

  • (modified) llvm/lib/Object/Archive.cpp (+1-1)
diff --git a/llvm/lib/Object/Archive.cpp b/llvm/lib/Object/Archive.cpp
index 753f805824cea..861c284253f7a 100644
--- a/llvm/lib/Object/Archive.cpp
+++ b/llvm/lib/Object/Archive.cpp
@@ -307,7 +307,7 @@ Expected<StringRef> ArchiveMemberHeader::getName(uint64_t Size) const {
       if (End == StringRef::npos || End < 1 ||
           Parent->getStringTable()[End - 1] != '/') {
         return malformedError("string table at long name offset " +
-                              Twine(StringOffset) + "not terminated");
+                              Twine(StringOffset) + " not terminated");
       }
       return Parent->getStringTable().slice(StringOffset, End - 1);
     }

@nico
Copy link
Contributor Author

nico commented Sep 19, 2025

Red CI looks unrelated. What do I do with that? Just ignore it and hit squash?

Copy link
Collaborator

@zmodem zmodem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zmodem
Copy link
Collaborator

zmodem commented Sep 19, 2025

Red CI looks unrelated. What do I do with that? Just ignore it and hit squash?

Either that, or if you want you could push something (like rebase and force push) to trigger a re-run.

@nico nico merged commit f847c2a into llvm:main Sep 20, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants