[IR] Modernize HasCachedHash (NFC) #159902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch modernizes HasCachedHash. - "struct SFINAE" is replaced with identically defined SameType. - The return types Yes and No are replaced with std::true_type and std::false_type. My previous attempt (llvm#159510) to clean up HasCachedHash failed on clang++-18, but this version works with clang++-18.
|
@llvm/pr-subscribers-llvm-ir Author: Kazu Hirata (kazutakahirata) ChangesThis patch modernizes HasCachedHash.
My previous attempt (#159510) to clean up HasCachedHash failed on Full diff: https://github.com/llvm/llvm-project/pull/159902.diff 1 Files Affected:
diff --git a/llvm/lib/IR/Metadata.cpp b/llvm/lib/IR/Metadata.cpp
index fc78a5b299f49..dc1651462aef4 100644
--- a/llvm/lib/IR/Metadata.cpp
+++ b/llvm/lib/IR/Metadata.cpp
@@ -986,15 +986,11 @@ static T *uniquifyImpl(T *N, DenseSet<T *, InfoT> &Store) {
}
template <class NodeTy> struct MDNode::HasCachedHash {
- using Yes = char[1];
- using No = char[2];
- template <class U, U Val> struct SFINAE {};
-
template <class U>
- static Yes &check(SFINAE<void (U::*)(unsigned), &U::setHash> *);
- template <class U> static No &check(...);
+ static std::true_type check(SameType<void (U::*)(unsigned), &U::setHash> *);
+ template <class U> static std::false_type check(...);
- static const bool value = sizeof(check<NodeTy>(nullptr)) == sizeof(Yes);
+ static constexpr bool value = decltype(check<NodeTy>(nullptr))::value;
};
MDNode *MDNode::uniquify() {
|
arsenm
approved these changes
Sep 20, 2025
kuhar
approved these changes
Sep 20, 2025
kazutakahirata
deleted the
cleanup_20250919_10TMP_IR_HasCachedHash_take2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modernizes HasCachedHash.
"struct SFINAE" is replaced with identically defined SameType.
The return types Yes and No are replaced with std::true_type and
std::false_type.
My previous attempt (#159510) to clean up HasCachedHash failed on
clang++-18, but this version works with clang++-18.