Skip to content

Conversation

@HerrCai0907
Copy link
Contributor

Fixed: #159409
clang_target_link_libraries can only be used for clang libraries. The libararies in here will not be link when LLVM_LINK_LLVM_DYLIB is enabled.

Fixed: llvm#159409
`clang_target_link_libraries` can only be used for clang libraries. The libararies in here will not be link when `LLVM_LINK_LLVM_DYLIB` is enabled.
@llvmbot
Copy link
Member

llvmbot commented Sep 20, 2025

@llvm/pr-subscribers-clang-tools-extra

@llvm/pr-subscribers-clang-tidy

Author: Congcong Cai (HerrCai0907)

Changes

Fixed: #159409
clang_target_link_libraries can only be used for clang libraries. The libararies in here will not be link when LLVM_LINK_LLVM_DYLIB is enabled.


Full diff: https://github.com/llvm/llvm-project/pull/159919.diff

1 Files Affected:

  • (modified) clang-tools-extra/clang-tidy/custom/CMakeLists.txt (+1-1)
diff --git a/clang-tools-extra/clang-tidy/custom/CMakeLists.txt b/clang-tools-extra/clang-tidy/custom/CMakeLists.txt
index 7d4b7ddb7c1b8..1af25a900113c 100644
--- a/clang-tools-extra/clang-tidy/custom/CMakeLists.txt
+++ b/clang-tools-extra/clang-tidy/custom/CMakeLists.txt
@@ -9,6 +9,7 @@ if(CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS)
     QueryCheck.cpp
 
     LINK_LIBS
+    clangQuery
     clangTidy
     clangTidyBugproneModule
     clangTidyMiscModule
@@ -31,7 +32,6 @@ if(CLANG_TIDY_ENABLE_QUERY_BASED_CUSTOM_CHECKS)
     clangDynamicASTMatchers
     clangFrontend
     clangLex
-    clangQuery
     clangSerialization
     clangTooling
   )

@HerrCai0907 HerrCai0907 enabled auto-merge (squash) September 20, 2025 12:22
@HerrCai0907 HerrCai0907 merged commit eff6b77 into llvm:main Sep 20, 2025
8 of 9 checks passed
@HerrCai0907 HerrCai0907 deleted the fix/159409 branch September 20, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants