From 0301722a5ff14e9eefe43e792916af4f78087007 Mon Sep 17 00:00:00 2001 From: Tobias Stadler Date: Fri, 26 Sep 2025 03:38:38 +0100 Subject: [PATCH 1/2] [spr] initial version Created using spr 1.3.7-wip --- llvm/tools/llvm-remarkutil/RemarkFilter.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/llvm/tools/llvm-remarkutil/RemarkFilter.cpp b/llvm/tools/llvm-remarkutil/RemarkFilter.cpp index acfef6608677c..14fbcf0314a47 100644 --- a/llvm/tools/llvm-remarkutil/RemarkFilter.cpp +++ b/llvm/tools/llvm-remarkutil/RemarkFilter.cpp @@ -20,8 +20,6 @@ using namespace llvm; using namespace remarks; using namespace llvm::remarkutil; -namespace filter { - static cl::SubCommand FilterSub("filter", "Filter remarks based on specified criteria."); @@ -80,5 +78,3 @@ static Error tryFilter() { } static CommandRegistration FilterReg(&FilterSub, tryFilter); - -} // namespace filter From 865dbc942e20ba505e41e37a51ccc3d265243ea7 Mon Sep 17 00:00:00 2001 From: Tobias Stadler Date: Fri, 26 Sep 2025 13:30:13 +0100 Subject: [PATCH 2/2] Add comment Created using spr 1.3.7-wip --- llvm/tools/llvm-remarkutil/RemarkFilter.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/llvm/tools/llvm-remarkutil/RemarkFilter.cpp b/llvm/tools/llvm-remarkutil/RemarkFilter.cpp index 14fbcf0314a47..507ae36f4a594 100644 --- a/llvm/tools/llvm-remarkutil/RemarkFilter.cpp +++ b/llvm/tools/llvm-remarkutil/RemarkFilter.cpp @@ -20,6 +20,10 @@ using namespace llvm; using namespace remarks; using namespace llvm::remarkutil; +// Note: Avoid using the identifier "filter" in this file, as it is prone to +// namespace collision with headers that might get included e.g. +// curses.h. + static cl::SubCommand FilterSub("filter", "Filter remarks based on specified criteria.");