Skip to content

[SPARC] Prevent meta instructions from being inserted into delay slots #161111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koachan merged 3 commits into from
Oct 3, 2025
Merged

[SPARC] Prevent meta instructions from being inserted into delay slots #161111

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab7b98f
[SPARC] Prevent generic opcodes from being inserted into delay slots
koachan Sep 29, 2025
43a45db
Apply feedback
koachan Oct 3, 2025
1b209d8
Remove redundant debug check
koachan Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/lib/Target/Sparc/DelaySlotFiller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,8 @@ Filler::findDelayInstr(MachineBasicBlock &MBB,
if (!done)
--I;

// skip debug instruction
if (I->isDebugInstr())
// Skip debug and meta instructions.
if (I->isDebugInstr() || I->isMetaInstruction())
continue;

if (I->hasUnmodeledSideEffects() || I->isInlineAsm() || I->isPosition() ||
Expand Down
25 changes: 25 additions & 0 deletions llvm/test/CodeGen/SPARC/2011-01-19-DelaySlot.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,4 +184,29 @@ entry:
ret i32 %2
}

define i32 @test_generic_inst(i32 %arg) #0 {
;CHECK-LABEL: test_generic_inst:
;CHECK: ! fake_use: {{.*}}
;CHECK: bne {{.*}}
;CHECK-NEXT: nop
%bar1 = call i32 @bar(i32 %arg)
%even = and i32 %bar1, 1
%cmp = icmp eq i32 %even, 0
; This shouldn't get reordered into a delay slot
call void (...) @llvm.fake.use(i32 %arg)
br i1 %cmp, label %true, label %false
true:
%bar2 = call i32 @bar(i32 %bar1)
br label %cont

false:
%inc = add nsw i32 %bar1, 1
br label %cont

cont:
%ret = phi i32 [ %bar2, %true ], [ %inc, %false ]
ret i32 %ret
}

declare void @llvm.fake.use(...)
attributes #0 = { nounwind "disable-tail-calls"="true" }
Loading