[lldb][NFCI] Remove the non-const reference Mangled::GetMangledName accessor #161495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccessor We've been seen (very sporadic) lifetime issues around this area. We noticed that `GetMangledName` has two accessors, one of which returns a non-const reference. I audited all the callsites and no users of this overload actually mutate the `ConstString` itself (which is a suspicious thing to do anyway since it's just a wrapper around a `const char*`). This patch removes the redundant overload. rdar://161128180
Member
|
@llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) ChangesWe've been seen (very sporadic) lifetime issues around this area. We noticed that This patch removes the redundant overload. rdar://161128180 Full diff: https://github.com/llvm/llvm-project/pull/161495.diff 1 Files Affected:
diff --git a/lldb/include/lldb/Core/Mangled.h b/lldb/include/lldb/Core/Mangled.h
index 47f1c6a8d80b7..1dcc34b4989dd 100644
--- a/lldb/include/lldb/Core/Mangled.h
+++ b/lldb/include/lldb/Core/Mangled.h
@@ -148,13 +148,7 @@ class Mangled {
/// Mangled name get accessor.
///
/// \return
- /// A reference to the mangled name string object.
- ConstString &GetMangledName() { return m_mangled; }
-
- /// Mangled name get accessor.
- ///
- /// \return
- /// A const reference to the mangled name string object.
+ /// A the mangled name string object.
ConstString GetMangledName() const { return m_mangled; }
/// Best name get accessor.
|
adrian-prantl
approved these changes
Oct 1, 2025
Collaborator
adrian-prantl
left a comment
adrian-prantl
left a comment
There was a problem hiding this comment.
This is a very pointless overload anyway.
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
…ccessor (llvm#161495) We've been seen (very sporadic) lifetime issues around this area. We noticed that `GetMangledName` has two accessors, one of which returns a non-const reference. I audited all the callsites and no users of this overload actually mutate the `ConstString` itself (which is a suspicious thing to do anyway since it's just a wrapper around a `const char*`). This patch removes the redundant overload. rdar://161128180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been seen (very sporadic) lifetime issues around this area. We noticed that
GetMangledNamehas two accessors, one of which returns a non-const reference. I audited all the callsites and no users of this overload actually mutate theConstStringitself (which is a suspicious thing to do anyway since it's just a wrapper around aconst char*).This patch removes the redundant overload.
rdar://161128180