Skip to content

Conversation

georgthegreat
Copy link
Contributor

Fixes the following compilation error:

$(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__ranges/lazy_split_view.h:143:10: error: '__outer_iterator' redeclared with 'public' access
  143 |   struct __outer_iterator : __outer_iterator_category<__maybe_const<_Const, _View>> {
      |          ^
$(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__ranges/lazy_split_view.h:79:10: note: previously declared 'private' here
   79 |   struct __outer_iterator;

Fixes the following compilation error:
```
$(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__ranges/lazy_split_view.h:143:10: error: '__outer_iterator' redeclared with 'public' access
  143 |   struct __outer_iterator : __outer_iterator_category<__maybe_const<_Const, _View>> {
      |          ^
$(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__ranges/lazy_split_view.h:79:10: note: previously declared 'private' here
   79 |   struct __outer_iterator;
```
@georgthegreat georgthegreat requested a review from a team as a code owner October 3, 2025 15:07
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Oct 3, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 3, 2025

@llvm/pr-subscribers-libcxx

Author: Yuriy Chernyshov (georgthegreat)

Changes

Fixes the following compilation error:

$(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__ranges/lazy_split_view.h:143:10: error: '__outer_iterator' redeclared with 'public' access
  143 |   struct __outer_iterator : __outer_iterator_category&lt;__maybe_const&lt;_Const, _View&gt;&gt; {
      |          ^
$(SOURCE_ROOT)/contrib/libs/cxxsupp/libcxx/include/__ranges/lazy_split_view.h:79:10: note: previously declared 'private' here
   79 |   struct __outer_iterator;

Full diff: https://github.com/llvm/llvm-project/pull/161859.diff

1 Files Affected:

  • (modified) libcxx/include/__ranges/lazy_split_view.h (+1)
diff --git a/libcxx/include/__ranges/lazy_split_view.h b/libcxx/include/__ranges/lazy_split_view.h
index cca9191d26818..7471579653d20 100644
--- a/libcxx/include/__ranges/lazy_split_view.h
+++ b/libcxx/include/__ranges/lazy_split_view.h
@@ -76,6 +76,7 @@ class lazy_split_view : public view_interface<lazy_split_view<_View, _Pattern>>
       _If<!forward_range<_View>, __non_propagating_cache<iterator_t<_View>>, __empty_cache>;
   _LIBCPP_NO_UNIQUE_ADDRESS _MaybeCurrent __current_ = _MaybeCurrent();
 
+private:
   template <bool>
   struct __outer_iterator;
   template <bool>

robot-piglet pushed a commit to yandex/yatool that referenced this pull request Oct 3, 2025
This backports [PR #161859](llvm/llvm-project#161859) from upstream.
commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
robot-piglet pushed a commit to yandex/perforator that referenced this pull request Oct 3, 2025
This backports [PR #161859](llvm/llvm-project#161859) from upstream.
commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
robot-piglet pushed a commit to ydb-platform/ydb that referenced this pull request Oct 3, 2025
This backports [PR #161859](llvm/llvm-project#161859) from upstream.
commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
robot-piglet pushed a commit to ytsaurus/ytsaurus that referenced this pull request Oct 3, 2025
This backports [PR #161859](llvm/llvm-project#161859) from upstream.
commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
robot-piglet pushed a commit to catboost/catboost that referenced this pull request Oct 3, 2025
This backports [PR #161859](llvm/llvm-project#161859) from upstream.
commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
robot-piglet pushed a commit to ytsaurus/ytsaurus that referenced this pull request Oct 4, 2025
This backports [PR #161859](llvm/llvm-project#161859) from upstream.
commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
maVovk pushed a commit to maVovk/ydb that referenced this pull request Oct 6, 2025
This backports [PR #161859](llvm/llvm-project#161859) from upstream.
commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
Copy link
Contributor

@philnik777 philnik777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you provide a reproducer/test for this? This looks to me like a compiler bug, not a libc++ bug.

neyrox pushed a commit to neyrox/ydb that referenced this pull request Oct 7, 2025
This backports [PR #161859](llvm/llvm-project#161859) from upstream.
commit_hash:55593669b4c3a7dd0109530c3cd78abff067c1f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants