Skip to content

[NFC] Fix deprecated use of lookupTarget in Kaleidoscope #162220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2025
Merged

[NFC] Fix deprecated use of lookupTarget in Kaleidoscope #162220

merged 1 commit into from
Oct 7, 2025

Conversation

@c8ef
Copy link
Contributor

@c8ef c8ef commented Oct 7, 2025

Related: 009da92

@c8ef c8ef requested review from boomanaiden154 and nikic October 7, 2025 04:19
boomanaiden154
boomanaiden154 approved these changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@boomanaiden154 boomanaiden154 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

Interesting that this doesn't seem to be wired up to build under LLVM_BUILD_EXAMPLES.

@c8ef c8ef merged commit a9c6c1d into llvm:main Oct 7, 2025
9 of 10 checks passed
@c8ef c8ef deleted the triple branch October 7, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boomanaiden154 boomanaiden154 boomanaiden154 approved these changes

@nikic nikic Awaiting requested review from nikic

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c8ef @boomanaiden154