[HIP][SPIRV] Use OPT_fembed_bitcode_EQ instead of the alias OPT_fembed_bitcode_marker #162258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he alias OPT_fembed_bitcode_markerpre commit
…d_bitcode_marker This helps avoid passing conflicting options if the user specified -fembed-bitcode= . OPT_fembed_bitcode_marker only matches -fembed-bitcode-marker. -fembed-bitcode=all/marker/none do not match. If the user specifies -fembed-bitcode=all/none, we should respect it, even if it may not make sense to us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps avoid passing conflicting options if the user specified
-fembed-bitcode= .
OPT_fembed_bitcode_marker only matches -fembed-bitcode-marker.
-fembed-bitcode=all/marker/none do not match.
If the user specifies -fembed-bitcode=all/none, we should respect it,
even if it may not make sense to us.