[AMDGPU][NFC] Fix clang frontend<->sema layering issue #162865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupprecht
added
the
skip-precommit-approval
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-amdgpu Author: Jordan Rupprecht (rupprecht) Changes#140210 added Fortunately, d076608 made this easy to fix, as clang/Frontend/FrontendDiagnostic.h just forwards to clang/Basic/DiagnosticFrontend.h, so it's trivial to make this depend on basic instead of frontend. Full diff: https://github.com/llvm/llvm-project/pull/162865.diff 1 Files Affected:
diff --git a/clang/lib/Sema/SemaAMDGPU.cpp b/clang/lib/Sema/SemaAMDGPU.cpp
index 45fe80de53fbc..e32f4376a5ebf 100644
--- a/clang/lib/Sema/SemaAMDGPU.cpp
+++ b/clang/lib/Sema/SemaAMDGPU.cpp
@@ -11,9 +11,9 @@
//===----------------------------------------------------------------------===//
#include "clang/Sema/SemaAMDGPU.h"
+#include "clang/Basic/DiagnosticFrontend.h"
#include "clang/Basic/DiagnosticSema.h"
#include "clang/Basic/TargetBuiltins.h"
-#include "clang/Frontend/FrontendDiagnostic.h"
#include "clang/Sema/Ownership.h"
#include "clang/Sema/Sema.h"
#include "llvm/Support/AMDGPUAddrSpace.h"
|
arsenm
approved these changes
Oct 10, 2025
rupprecht
added a commit
to rupprecht/llvm-project
that referenced
this pull request
Oct 10, 2025
…Frontend.h d076608 moved some deps around to avoid cycles and left clang/Frontend/FrontendDiagnostic.h as a shim that simply includes clang/Basic/DiagnosticFrontend.h. This PR inlines it so that nothing in tree still includes clang/Frontend/FrontendDiagnostic.h. Doing this will help prevent future layering issues. See llvm#162865.
DharuniRAcharya
pushed a commit
to DharuniRAcharya/llvm-project
that referenced
this pull request
Oct 13, 2025
llvm#140210 added `#include "clang/Frontend/FrontendDiagnostic.h"` to clang/lib/Sema/SemaAMDGPU.cpp, but Frontend itself has a dependency on Sema. This creates a layering issue as described in https://llvm.org/docs/CodingStandards.html#library-layering. Fortunately, d076608 made this easy to fix, as clang/Frontend/FrontendDiagnostic.h just forwards to clang/Basic/DiagnosticFrontend.h, so it's trivial to make this depend on basic instead of frontend.
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
llvm#140210 added `#include "clang/Frontend/FrontendDiagnostic.h"` to clang/lib/Sema/SemaAMDGPU.cpp, but Frontend itself has a dependency on Sema. This creates a layering issue as described in https://llvm.org/docs/CodingStandards.html#library-layering. Fortunately, d076608 made this easy to fix, as clang/Frontend/FrontendDiagnostic.h just forwards to clang/Basic/DiagnosticFrontend.h, so it's trivial to make this depend on basic instead of frontend.
rupprecht
added a commit
to rupprecht/llvm-project
that referenced
this pull request
Nov 20, 2025
…Frontend.h d076608 moved some deps around to avoid cycles and left clang/Frontend/FrontendDiagnostic.h as a shim that simply includes clang/Basic/DiagnosticFrontend.h. This PR inlines it so that nothing in tree still includes clang/Frontend/FrontendDiagnostic.h. Doing this will help prevent future layering issues. See llvm#162865.
rupprecht
added a commit
that referenced
this pull request
Nov 21, 2025
…Frontend.h (#162883) d076608 moved some deps around to avoid cycles and left clang/Frontend/FrontendDiagnostic.h as a shim that simply includes clang/Basic/DiagnosticFrontend.h. This PR inlines it so that nothing in tree still includes clang/Frontend/FrontendDiagnostic.h. Doing this will help prevent future layering issues. See #162865. Frontend already depends on Basic, so no new deps need to be added anywhere except for places that do strict dep checking.
aadeshps-mcw
pushed a commit
to aadeshps-mcw/llvm-project
that referenced
this pull request
Nov 26, 2025
…Frontend.h (llvm#162883) d076608 moved some deps around to avoid cycles and left clang/Frontend/FrontendDiagnostic.h as a shim that simply includes clang/Basic/DiagnosticFrontend.h. This PR inlines it so that nothing in tree still includes clang/Frontend/FrontendDiagnostic.h. Doing this will help prevent future layering issues. See llvm#162865. Frontend already depends on Basic, so no new deps need to be added anywhere except for places that do strict dep checking.
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Nov 26, 2025
…Frontend.h (llvm#162883) d076608 moved some deps around to avoid cycles and left clang/Frontend/FrontendDiagnostic.h as a shim that simply includes clang/Basic/DiagnosticFrontend.h. This PR inlines it so that nothing in tree still includes clang/Frontend/FrontendDiagnostic.h. Doing this will help prevent future layering issues. See llvm#162865. Frontend already depends on Basic, so no new deps need to be added anywhere except for places that do strict dep checking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#140210 added
#include "clang/Frontend/FrontendDiagnostic.h"to clang/lib/Sema/SemaAMDGPU.cpp, but Frontend itself has a dependency on Sema. This creates a layering issue as described in https://llvm.org/docs/CodingStandards.html#library-layering.Fortunately, d076608 made this easy to fix, as clang/Frontend/FrontendDiagnostic.h just forwards to clang/Basic/DiagnosticFrontend.h, so it's trivial to make this depend on basic instead of frontend.