[gn] Fix after c37c82de1acbec165d39d725fe1c7e1d96710219 #163227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
|
I think we would want to create a LifetimeSafety library to match the CMake one, then llvm/utils/gn/build/sync_source_lists_from_cmake.py would be able to update it automatically. |
Done |
Created using spr 1.3.4
pcc
reviewed
Oct 13, 2025
| @@ -0,0 +1,20 @@ | |||
| static_library("LifetimeSafety") { | |||
| output_name = "clangLifetimeSafety" | |||
There was a problem hiding this comment.
clangAnalysisLifetimeSafety to match cmake.
pcc
approved these changes
Oct 13, 2025
fmayer
deleted the
users/fmayer/spr/gn-fix-after-c37c82de1acbec165d39d725fe1c7e1d96710219
branch
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.