-
Notifications
You must be signed in to change notification settings - Fork 15.4k
[AArch64][GlobalISel] Improve lowering of vector fp16 fptrunc #163398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davemgreen
merged 21 commits into
llvm:main
from
HolyMolyCowMan:fp16-fptrunc-fpext-lowering
Nov 28, 2025
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
737470e
[AArch64][GlobalISel] Improve lowering of vector fp16 fptrunc and fpext
HolyMolyCowMan ae3ef1e
Address review comments
HolyMolyCowMan 43b1509
Separate FPEXT & FPTRUNC changes
HolyMolyCowMan 437caa3
Add new opcode for rounding to odd
HolyMolyCowMan 6abe127
Disable combiner
HolyMolyCowMan 13fc5dc
Use tablegen for matching
HolyMolyCowMan 0ceacd7
Remove unused code
HolyMolyCowMan 8b85744
Update tests
HolyMolyCowMan ec102fc
Move from a custom legalize function to lowering
HolyMolyCowMan 411afc0
Linting
HolyMolyCowMan 60b6da7
Update vocab & entities lists
HolyMolyCowMan 76a03d6
Update reference_triplets.txt
HolyMolyCowMan a5635b7
Add trailing new line to reference_triplets.txt
HolyMolyCowMan 5f97537
Add G_FPTRUNC_ODD to generic opcodes & check legality before emitting…
HolyMolyCowMan 3671057
Undo removal of newline
HolyMolyCowMan 39c3e04
Remove shared opcode & subsequent changes
HolyMolyCowMan 0604176
Rework to make AArch64 specific & handle splitting into legal chunks
HolyMolyCowMan 3513809
Merge remote-tracking branch 'origin/main' into fp16-fptrunc-fpext-lo…
HolyMolyCowMan 74aa139
Linting
HolyMolyCowMan a1bf07a
Update tests
HolyMolyCowMan 60cbbc7
Remove unnecessary brackets, revert a change & modify comment
HolyMolyCowMan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we make this work with a "multiple of 2", not a "power of 2"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do but currently the legalizer widens the fptrunc src to the next power of 2, meaning we can keep this simple if we only expect powers of 2. Otherwise, we might have to pad vectors so we can later concat them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - that fine for now then. We should go through at some point and check non-power2 vector types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add a todo comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No thats fine, we need to go through all of them I think.