Skip to content

[mlir] Use isPure and skipRegions to print region op (NFC) #163422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linuxlonelyeagle merged 1 commit into from
Oct 14, 2025
Merged

[mlir] Use isPure and skipRegions to print region op (NFC) #163422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ size_t mlir::moveLoopInvariantCode(
size_t numMoved = 0;

for (Region *region : regions) {
LDBG() << "Original loop:\n" << *region->getParentOp();
LDBG() << "Original loop:\n"
<< OpWithFlags(region->getParentOp(),
OpPrintingFlags().skipRegions());

std::queue<Operation *> worklist;
// Add top-level operations in the loop body to the worklist.
Expand All @@ -90,7 +92,8 @@ size_t mlir::moveLoopInvariantCode(
!canBeHoisted(op, definedOutside))
continue;

LDBG() << "Moving loop-invariant op: " << *op;
LDBG() << "Moving loop-invariant op: "
<< OpWithFlags(op, OpPrintingFlags().skipRegions());
moveOutOfRegion(op, region);
++numMoved;

Expand All @@ -111,9 +114,7 @@ size_t mlir::moveLoopInvariantCode(LoopLikeOpInterface loopLike) {
[&](Value value, Region *) {
return loopLike.isDefinedOutsideOfLoop(value);
},
[&](Operation *op, Region *) {
return isMemoryEffectFree(op) && isSpeculatable(op);
},
[&](Operation *op, Region *) { return isPure(op); },
[&](Operation *op, Region *) { loopLike.moveOutOfLoop(op); });
}

Expand Down