[objdump] Fix dxcontainer tests on big endian host #163427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a build regression on big endian systems introduced in ../llvm/test/tools/llvm-objcopy/DXContainer/dump-section.yaml
Member
|
@llvm/pr-subscribers-llvm-binary-utilities @llvm/pr-subscribers-backend-directx Author: Chris B (llvm-beanz) ChangesThis fixes a build regression on big endian systems introduced in ../llvm/test/tools/llvm-objcopy/DXContainer/dump-section.yaml Full diff: https://github.com/llvm/llvm-project/pull/163427.diff 1 Files Affected:
diff --git a/llvm/test/tools/llvm-objcopy/DXContainer/dump-section.yaml b/llvm/test/tools/llvm-objcopy/DXContainer/dump-section.yaml
index 6f1ecb96929cd..48773269724a4 100644
--- a/llvm/test/tools/llvm-objcopy/DXContainer/dump-section.yaml
+++ b/llvm/test/tools/llvm-objcopy/DXContainer/dump-section.yaml
@@ -11,7 +11,7 @@
## Dump the PSV0 part and verify its size.
# RUN: llvm-objcopy --dump-section=PSV0=%t.psv0 %t.dxbc
# RUN: wc -c %t.psv0 | FileCheck %s --check-prefix=PSV0-SIZE
-# RUN: od -h %t.psv0 | FileCheck %s --check-prefix=PSV0-CONTENTS
+# RUN: od -v -Ax -t x1 %t.psv0 | FileCheck %s --check-prefix=PSV0-CONTENTS
# PSV0-SIZE: 76
# For a compute shader the structure size is encoded followed by a bunch of 00'd
@@ -20,8 +20,8 @@
# TODO: Update this test to use objdump or obj2yaml once we support
# --add-section in objcopy. See issue:
# https://github.com/llvm/llvm-project/issues/162159.
-# PSV0-CONTENTS: 0000000 0034 0000 0000 0000 0000 0000 0000 0000
-# PSV0-CONTENTS: 0000020 0000 0000 0000 0000 ffff ffff 0005 0000
+# PSV0-CONTENTS: 0000000 34 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
+# PSV0-CONTENTS: 0000010 00 00 00 00 00 00 00 00 ff ff ff ff 05 00 00 00
--- !dxcontainer
Header:
|
bogner
approved these changes
Oct 14, 2025
damyanp
approved these changes
Oct 14, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/37816 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/17500 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/23408 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/185/builds/27111 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/175/builds/27091 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/27247 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/33/builds/24788 Here is the relevant piece of the build log for the reference |
Contributor
|
Looks like this might have broken little endian systems... The premerge checks failed on the PR before landing as well. Are you able to quickly fix forward or revert? |
Contributor
|
Ah, looks like df258c0 covers it. Thanks! |
Collaborator
Author
This wasn't related to endian-ness, it is that some implementations of
Fix is in. The pre-merge checks here are a bit tricky to grok. AArch64 succeeded, but the Linux x86 failed and the failure message is buried in the middle of an extremely long build log. I did look at the Linux failure before I hit the merge button, but the log ended with no clear indication of which sub-action failed just an opaque python script reported failure. That led me to (incorrectly) assume this was a tooling error not caused by my change. It would be nice if we could split the build tasks so that the logs get broken up into smaller pieces where we can reasonably expect that the failures would be at the end instead of the middle. |
Contributor
https://github.com/llvm/llvm-project/actions/runs/18504981382 has a rich representation of the failures. We're still working on trying to make it more discoverable, probably through a comment mechanism similar to the code format action. We're still working on finishing some other stuff up before we get to doing exactly that though.
Splitting things up makes local reproduction harder because now you cannot just run a single step. Big chunks of the log are theoretically collapsible, but there are enough log lines that Github doesn't always render things properly. |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/26601 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/26741 Here is the relevant piece of the build log for the reference |
akadutta
pushed a commit
to akadutta/llvm-project
that referenced
this pull request
Oct 14, 2025
This fixes a build regression on big endian systems introduced in llvm#159999.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a build regression on big endian systems introduced in #159999.