Skip to content

[VPlan] Strip stale comment for SCEVToExpansion (NFC) #164288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+0 −2
Closed

[VPlan] Strip stale comment for SCEVToExpansion (NFC) #164288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions llvm/lib/Transforms/Vectorize/VPlan.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4164,8 +4164,6 @@ class VPlan {
SmallVector<VPValue *, 16> VPLiveIns;

/// Mapping from SCEVs to the VPValues representing their expansions.
/// NOTE: This mapping is temporary and will be removed once all users have
Copy link
Contributor

@fhahn fhahn Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting one, originally I was a bit surprised and while trying to confirm if the TODO is still needed it turns out the while map isn't needed any longer: https://github.com/llvm/llvm-project/pull/164490/files

/// been modeled in VPlan directly.
DenseMap<const SCEV *, VPValue *> SCEVToExpansion;

/// Blocks allocated and owned by the VPlan. They will be deleted once the
Expand Down
Loading