[lldb] add a warning if dirname is not in the PATH
#164494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-lldb Author: Charles Zablit (charles-zablit) ChangesThis patch adds a check in lldb's API test CMakeLists file to ensure that Full diff: https://github.com/llvm/llvm-project/pull/164494.diff 1 Files Affected:
diff --git a/lldb/test/API/CMakeLists.txt b/lldb/test/API/CMakeLists.txt
index b1ace6296f46a..df2648d3c3518 100644
--- a/lldb/test/API/CMakeLists.txt
+++ b/lldb/test/API/CMakeLists.txt
@@ -74,6 +74,15 @@ else()
endif()
endif()
+find_program(LLDB_DIRNAME_PATH dirname)
+if(LLDB_DIRNAME_PATH)
+ message(STATUS "Found dirname: ${LLDB_DIRNAME_PATH}")
+else()
+ message(STATUS "Did not find 'dirname'.")
+ message(WARNING
+ "Many LLDB API tests require the 'dirname' tool. Please provide it in Path.")
+endif()
+
if (TARGET clang)
set(LLDB_DEFAULT_TEST_COMPILER "${LLVM_TOOLS_BINARY_DIR}/clang${CMAKE_EXECUTABLE_SUFFIX}")
else()
|
Nerixyz
reviewed
Oct 21, 2025
lldb/test/API/CMakeLists.txt
Outdated
Comment on lines
82
to
83
| message(WARNING | ||
| "Many LLDB API tests require the 'dirname' tool. Please provide it in Path.") |
Contributor
There was a problem hiding this comment.
This warning message could be more generic and mention that tests require the coreutils.
charles-zablit
added a commit
to charles-zablit/llvm-project
that referenced
this pull request
Oct 22, 2025
This patch adds a check in lldb's API test CMakeLists file to ensure that `dirname` is in the PATH, which is not obvious on Windows. --------- Co-authored-by: nerix <[email protected]>
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
This patch adds a check in lldb's API test CMakeLists file to ensure that `dirname` is in the PATH, which is not obvious on Windows. --------- Co-authored-by: nerix <[email protected]>
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
This patch adds a check in lldb's API test CMakeLists file to ensure that `dirname` is in the PATH, which is not obvious on Windows. --------- Co-authored-by: nerix <[email protected]>
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
This patch adds a check in lldb's API test CMakeLists file to ensure that `dirname` is in the PATH, which is not obvious on Windows. --------- Co-authored-by: nerix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a check in lldb's API test CMakeLists file to ensure that
dirnameis in the PATH, which is not obvious on Windows.