Skip to content

[lldb] add a warning if dirname is not in the PATH #164494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 22, 2025
Merged

[lldb] add a warning if dirname is not in the PATH #164494

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13cdc22
[lldb] add a warning if `dirname` is not in the PATH
charles-zablit Oct 21, 2025
0e5bcf5
Update lldb/test/API/CMakeLists.txt
charles-zablit Oct 21, 2025
6a7c6e4
fixup! [lldb] add a warning if `dirname` is not in the PATH
charles-zablit Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lldb/test/API/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,15 @@ else()
endif()
endif()

find_program(LLDB_DIRNAME_PATH dirname)
if(LLDB_DIRNAME_PATH)
message(STATUS "Found dirname: ${LLDB_DIRNAME_PATH}")
else()
message(STATUS "Did not find 'dirname'.")
message(WARNING
"Many LLDB API tests require the 'dirname' tool. Please provide it in Path.")
Copy link
Contributor

@Nerixyz Nerixyz Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This warning message could be more generic and mention that tests require the coreutils.

endif()

if (TARGET clang)
set(LLDB_DEFAULT_TEST_COMPILER "${LLVM_TOOLS_BINARY_DIR}/clang${CMAKE_EXECUTABLE_SUFFIX}")
else()
Expand Down
Loading