[DirectX] Use a well-formed cbuffer in the unused cbuffer test #164844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CBuffers still need a layout type for now. Fix the crash when looking up the cbuffer info.
|
@llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) ChangesCBuffers still need a layout type for now. Fix the crash when looking up the cbuffer info. Full diff: https://github.com/llvm/llvm-project/pull/164844.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/DirectX/CBufferAccess/unused.ll b/llvm/test/CodeGen/DirectX/CBufferAccess/unused.ll
index 8c0d82e43b4b1..6f1bbd050bd7c 100644
--- a/llvm/test/CodeGen/DirectX/CBufferAccess/unused.ll
+++ b/llvm/test/CodeGen/DirectX/CBufferAccess/unused.ll
@@ -2,7 +2,7 @@
; Check that we correctly ignore cbuffers that were nulled out by optimizations.
%__cblayout_CB = type <{ float }>
-@CB.cb = local_unnamed_addr global target("dx.CBuffer", %__cblayout_CB) poison
+@CB.cb = local_unnamed_addr global target("dx.CBuffer", target("dx.Layout", %__cblayout_CB, 4, 0)) poison
@x = external local_unnamed_addr addrspace(2) global float, align 4
; CHECK-NOT: !hlsl.cbs =
|
V-FEXrt
approved these changes
Oct 23, 2025
farzonl
approved these changes
Oct 23, 2025
dvbuka
pushed a commit
to dvbuka/llvm-project
that referenced
this pull request
Oct 27, 2025
…164844) CBuffers still need a layout type for now. Fix the crash when looking up the cbuffer info.
Lukacma
pushed a commit
to Lukacma/llvm-project
that referenced
this pull request
Oct 29, 2025
…164844) CBuffers still need a layout type for now. Fix the crash when looking up the cbuffer info.
aokblast
pushed a commit
to aokblast/llvm-project
that referenced
this pull request
Oct 30, 2025
…164844) CBuffers still need a layout type for now. Fix the crash when looking up the cbuffer info.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBuffers still need a layout type for now. Fix the crash when looking up the cbuffer info.