-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[CI] Make Premerge Advisor Upload to Both Advisor Instances #165058
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Make Premerge Advisor Upload to Both Advisor Instances #165058
Conversation
Created using spr 1.3.7
|
@llvm/pr-subscribers-infrastructure Author: Aiden Grossman (boomanaiden154) ChangesSo that we do not have to worry about synchronizing data between the two Full diff: https://github.com/llvm/llvm-project/pull/165058.diff 1 Files Affected:
diff --git a/.ci/premerge_advisor_upload.py b/.ci/premerge_advisor_upload.py
index 1fc2423dd24fc..a50c8c4765bef 100644
--- a/.ci/premerge_advisor_upload.py
+++ b/.ci/premerge_advisor_upload.py
@@ -12,9 +12,10 @@
import generate_test_report_lib
-PREMERGE_ADVISOR_URL = (
- "http://premerge-advisor.premerge-advisor.svc.cluster.local:5000/upload"
-)
+PREMERGE_ADVISOR_URLS = [
+ "http://34.82.126.63:5000/upload",
+ "http://136.114.125.23:5000/upload",
+]
def main(commit_sha, workflow_run_number, build_log_files):
@@ -41,7 +42,8 @@ def main(commit_sha, workflow_run_number, build_log_files):
ninja_failures = generate_test_report_lib.find_failure_in_ninja_logs(ninja_logs)
for name, failure_message in ninja_failures:
failure_info["failures"].append({"name": name, "message": failure_message})
- requests.post(PREMERGE_ADVISOR_URL, json=failure_info)
+ for premerge_advisor_url in PREMERGE_ADVISOR_URLS:
+ requests.post(premerge_advisor_url, json=failure_info)
if __name__ == "__main__":
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Suggested possibly adding a comment.
So that we do not have to worry about synchronizing data between the two clusters. This also enables this script to work on AArch64, although we'll look at enabling that later. Reviewers: cmtice Reviewed By: cmtice Pull Request: llvm/llvm-project#165058
So that we do not have to worry about synchronizing data between the two clusters. This also enables this script to work on AArch64, although we'll look at enabling that later. Reviewers: cmtice Reviewed By: cmtice Pull Request: llvm#165058
So that we do not have to worry about synchronizing data between the two clusters. This also enables this script to work on AArch64, although we'll look at enabling that later. Reviewers: cmtice Reviewed By: cmtice Pull Request: llvm#165058
So that we do not have to worry about synchronizing data between the two clusters. This also enables this script to work on AArch64, although we'll look at enabling that later. Reviewers: cmtice Reviewed By: cmtice Pull Request: llvm#165058
So that we do not have to worry about synchronizing data between the two
clusters. This also enables this script to work on AArch64, although
we'll look at enabling that later.