Skip to content

[llvm-libgcc] Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_… #165487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[llvm-libgcc] Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_… #165487

wants to merge 2 commits into from
+21 −5

Conversation

@kraj
Copy link
Contributor

@kraj kraj commented Oct 28, 2025

…RUNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so which is functionally correct but it fails some linux distro packaging complain because libunwind.so is made part of -dev package but libgcc_so.1.0 ends up in the real package, and creates an unneeded package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries of packaging are not crossed and all is well.

@kraj
Fix symlink path for libgcc
d21ab66 
The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.
@kraj kraj force-pushed the users/kraj/llvm-libgcc-symlink-fixes branch from 4204fd1 to d21ab66 Compare October 29, 2025 00:24
@kraj kraj requested a review from petrhosek October 29, 2025 01:41
@kraj
[llvm-libgcc] Fix libgcc.a symlink path when LLVM_ENABLE_PER_TARGET_R…
919fcd1 
…UNTIME_DIR=OFF

The llvm-libgcc installation was creating incorrect symlinks for libgcc.a
when built with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF, particularly seen with
Yocto cross-compilation environments.

Issues seen:

-  Absolute path in symlink: The previous code didn't handle absolute paths
   returned by get_compiler_rt_install_dir() in staging/sysroot environments,
   resulting in symlinks like:
   libgcc.a -> /absolute/path/to/sysroot/usr/lib/clang/.../libclang_rt.builtins.a

-  Missing architecture suffix: When the install path contained "clang", the
   code would skip setting builtins_suffix, creating:
   libgcc.a -> clang/21.1.4/lib/linux/libclang_rt.builtins.a
   instead of:
   libgcc.a -> clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

-  Incorrect relative path calculation: The original regex stripped too much
   or too little of the path, either creating symlinks pointing to non-existent
   locations or stripping the clang/ directory prefix entirely.

Solution:

- Extract the relative path starting from 'clang/' when present in absolute
  paths, ensuring the symlink points to the correct location within the
  installation hierarchy
- Always append the architecture suffix to the builtins library name
- Only prepend '../' to the path when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is
  enabled, as this is when the builtins are in a different directory level

The symlink now correctly points to the existing compiler-rt builtins library
without creating duplicate copies.

Tested with LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF in cross-compilation
environments (aarch64 target).
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 5, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
f2270c0 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 5, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
6dc2b08 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 5, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
2a07191 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 6, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
b1e85c2 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 6, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
64994d4 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 6, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
1a63f9e 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 8, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
98a0777 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 8, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
35ead2d 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 9, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
12acea4 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 10, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
7aef6e4 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 10, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
fe9e40b 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 13, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
54d150f 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 14, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
db402b1 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 14, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
e890510 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 14, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
57b0b94 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 16, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
c67449f 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 16, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
7042c8b 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 16, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
92aaf76 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 17, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
4640d00 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 19, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
5e9b696 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 20, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
43941e9 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 20, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
94a4b09 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 20, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
487a930 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 20, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
a9b3313 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 21, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
bc7c834 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 21, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
1e06aba 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 22, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
437247b 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 22, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
87e00ea 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 24, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
8f3bd13 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 24, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
e118413 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 24, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
f3df332 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 24, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
e06ea50 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 25, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
72ea512 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 25, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
324ee91 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 25, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
b008700 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 27, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
3472f12 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 27, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
4659351 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 27, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
5f5806b 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 28, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
0a04431 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 29, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
bbc7060 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 30, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
de1dcfd 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Nov 30, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
0f370c4 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Dec 1, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
192d559 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Dec 1, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
4718092 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Dec 1, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
691d17a 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Dec 2, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
5918697 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Dec 2, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
8c4cdbc 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Dec 3, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
058fe79 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
kraj added a commit to kraj/llvm-project that referenced this pull request Dec 3, 2025
@kraj
llvm-libgcc: Fix symlink path for libcc when LLVM_ENABLE_PER_TARGET_R…
d2d78db 
…UNTIME_DIR is unset

current logic fails when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR = OFF
and it ends up with symlinks e.g.

libgcc.a -> ..//usr/lib/clang/21.1.4/lib/linux/libclang_rt.builtins.a

the real library is at
../lib/clang/21.1.4/lib/linux/libclang_rt.builtins-aarch64.a

The relative path is incorrect and its missing to add -arch suffix
as well.

So we make checks a bit more explicit to cover this case.

The symlink for libgcc_so.1.0 is made to point to libunwind.so
which is functionally correct but it fails some linux distro packaging
complain because libunwind.so is made part of -dev package but
libgcc_so.1.0 ends up in the real package, and creates an unneeded
package -> dev dependency

create the symlink to point to libunwind.so.1 instead then the boundaries
of packaging are not crossed and all is well.

Upstream-Status: Submitted [llvm#165487]
Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrhosek petrhosek Awaiting requested review from petrhosek

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kraj