Skip to content

[clang-tidy] Fix readability-container-data-pointer check #165636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 9, 2025
Merged

[clang-tidy] Fix readability-container-data-pointer check #165636

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f29accd
[clang-tidy] Fix `readability-container-data-pointer` check
zeyi2 Oct 29, 2025
b7dcb77
add release notes and fix minor issue
zeyi2 Oct 30, 2025
76bc6cf
fix docs
zeyi2 Oct 30, 2025
f63a789
Add more tests
zeyi2 Oct 31, 2025
1c60089
minor fix
zeyi2 Oct 31, 2025
4170744
fix format issue
zeyi2 Oct 31, 2025
3c551a9
fix `AsIs`
zeyi2 Nov 3, 2025
0eaa462
Revert "fix `AsIs`"
zeyi2 Nov 9, 2025
f981d8c
Revert "fix format issue"
zeyi2 Nov 9, 2025
f8193db
Revert "minor fix"
zeyi2 Nov 9, 2025
253c39d
Revert "Add more tests"
zeyi2 Nov 9, 2025
4ebc962
Update clang-tools-extra/test/clang-tidy/checkers/readability/contain…
zeyi2 Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,11 @@ void ContainerDataPointerCheck::check(const MatchFinder::MatchResult &Result) {
Lexer::getSourceText(CharSourceRange::getTokenRange(SrcRange),
*Result.SourceManager, getLangOpts())};

if (!isa<DeclRefExpr, ArraySubscriptExpr, CXXOperatorCallExpr, CallExpr,
MemberExpr>(CE))
const auto *OpCall = dyn_cast<CXXOperatorCallExpr>(CE);
bool NeedsParens =
OpCall ? (OpCall->getOperator() != OO_Subscript)
: !isa<DeclRefExpr, MemberExpr, ArraySubscriptExpr, CallExpr>(CE);
if (NeedsParens)
ReplacementText = "(" + ReplacementText + ")";

if (CE->getType()->isPointerType())
Expand Down
12 changes: 12 additions & 0 deletions clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ template <typename T>
struct enable_if<true, T> {
typedef T type;
};

template <typename T>
struct unique_ptr {
T &operator*() const;
T *operator->() const;
};
}

template <typename T>
Expand Down Expand Up @@ -144,3 +150,9 @@ int *r() {
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
// CHECK-FIXES: return holder.v.data();
}

void s(std::unique_ptr<std::vector<unsigned char>> p) {
f(&(*p)[0]);
// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: 'data' should be used for accessing the data pointer instead of taking the address of the 0-th element [readability-container-data-pointer]
// CHECK-FIXES: f((*p).data());
}