[compiler-rt][Profile] Temporarily Disable Test on AIX

[boomanaiden154]

This was very hackily patched in
16ef893 to not use env -u. The internal
shell does not support unset, but does supprt env -u. Disable the test
for now so we can enable the internal shell with a TODO to enable it
after the internal shell landing has stuck.

[llvmbot]

@llvm/pr-subscribers-pgo

Author: Aiden Grossman (boomanaiden154)

Changes

This was very hackily patched in
16ef893 to not use env -u. The internal
shell does not support unset, but does supprt env -u. Disable the test
for now so we can enable the internal shell with a TODO to enable it
after the internal shell landing has stuck.

---

Full diff: https://github.com/llvm/llvm-project/pull/166637.diff

1 Files Affected:

• (modified) compiler-rt/test/profile/instrprof-tmpdir.c (+6-2)

diff --git a/compiler-rt/test/profile/instrprof-tmpdir.c b/compiler-rt/test/profile/instrprof-tmpdir.c
index 7206df3c2eb0c..9d4b3d35e94e7 100644
--- a/compiler-rt/test/profile/instrprof-tmpdir.c
+++ b/compiler-rt/test/profile/instrprof-tmpdir.c
@@ -1,3 +1,8 @@
+// AIX does not support env -u.
+// TODO(boomanaiden154): Reenable AIX support once we use the internal shell by
+// default.
+// UNSUPPORTED: system-aix
+
 // RUN: rm -rf %t
 // RUN: mkdir -p %t
 // RUN: cd %t
@@ -12,8 +17,7 @@
 // RUN: llvm-profdata show ./raw2.profraw | FileCheck %s -check-prefix TMPDIR
 //
 // Check that we fall back to the default path if TMPDIR is missing.
-// RUN: %if system-aix %{ unset TMPDIR %}
-// RUN: env %if !system-aix %{ -u TMPDIR %} LLVM_PROFILE_FILE="%%t/raw3.profraw" %run %t/binary 2>&1 | FileCheck %s -check-prefix MISSING
+// RUN: env -u TMPDIR LLVM_PROFILE_FILE="%%t/raw3.profraw" %run %t/binary 2>&1 | FileCheck %s -check-prefix MISSING
 // RUN: llvm-profdata show ./default.profraw | FileCheck %s -check-prefix TMPDIR
 
 // TMPDIR: Maximum function count: 1

[mingmingl-llvm]

Could you briefly elaborate on how to re-enable this test going forward and the approximate timeline?

[boomanaiden154]

Could you briefly elaborate on how to re-enable this test going forward and the approximate timeline?

Once the internal shell work lands, we can just remove the UNSUPPORTED line because the internal shell natively supports env -u. I would expect this to be reenabled in the next week or two.

[mingmingl-llvm]

Once the internal shell work lands, we can just remove the UNSUPPORTED line because the internal shell natively supports env -u. I would expect this to be reenabled in the next week or two.

thanks! If I understand correctly, this change is needed to unblock the internal shell landing. So an intermediate change LGTM.

Added @w2yehia in the reviewer list for visibility of this change.