-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[compiler-rt][HWAsan] Remove CHECK lines from test #166638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler-rt][HWAsan] Remove CHECK lines from test #166638
Conversation
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Aiden Grossman (boomanaiden154) ChangesThese check lines were added in 144dae2 This would cause failures on the internal shell given the (<command>) Full diff: https://github.com/llvm/llvm-project/pull/166638.diff 1 Files Affected:
diff --git a/compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c b/compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c
index fc83b213561c8..08a04fc305ffb 100644
--- a/compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c
+++ b/compiler-rt/test/hwasan/TestCases/Linux/fixed-shadow.c
@@ -3,12 +3,12 @@
// Default compiler instrumentation works with any shadow base (dynamic or fixed).
// RUN: %clang_hwasan %s -o %t
// RUN: %run %t
-// RUN: env HWASAN_OPTIONS=fixed_shadow_base=263878495698944 %run %t 2>%t.out || (cat %t.out | FileCheck %s)
+// RUN: env HWASAN_OPTIONS=fixed_shadow_base=263878495698944 %run %t
// RUN: env HWASAN_OPTIONS=fixed_shadow_base=4398046511104 %run %t
//
// If -hwasan-mapping-offset is set, then the fixed_shadow_base needs to match.
// RUN: %clang_hwasan %s -mllvm -hwasan-mapping-offset=263878495698944 -o %t
-// RUN: env HWASAN_OPTIONS=fixed_shadow_base=263878495698944 %run %t 2>%t.out || (cat %t.out | FileCheck %s)
+// RUN: env HWASAN_OPTIONS=fixed_shadow_base=263878495698944 %run %t
// RUN: env HWASAN_OPTIONS=fixed_shadow_base=4398046511104 not %run %t
// RUN: %clang_hwasan %s -mllvm -hwasan-mapping-offset=4398046511104 -o %t
@@ -26,8 +26,6 @@
//
// UNSUPPORTED: android
-// CHECK: FATAL: HWAddressSanitizer: Shadow range {{.*}} is not available
-
#include <assert.h>
#include <sanitizer/allocator_interface.h>
#include <sanitizer/hwasan_interface.h>
|
Created using spr 1.3.7 [skip ci]
These check lines were added in 144dae2 as part of reenabling on Linux. The check lines were added using an or clause though that gets short circuited, so were never actually executed. Fixing the short circuit so they do execute reveals the filecheck assertions no longer pass. Remove them for now given they did not exist in the original test. This would cause failures on the internal shell given the (<command>) syntax is not understood by the internal shell. Pull Request: llvm#166638
These check lines were added in 144dae2 as part of reenabling on Linux. The check lines were added using an or clause though that gets short circuited, so were never actually executed. Fixing the short circuit so they do execute reveals the filecheck assertions no longer pass. Remove them for now given they did not exist in the original test. This would cause failures on the internal shell given the (<command>) syntax is not understood by the internal shell. Reviewers: vitalybuka, thurstond, fmayer Reviewed By: vitalybuka Pull Request: llvm/llvm-project#166638
These check lines were added in 144dae2
as part of reenabling on Linux. The check lines were added using an or
clause though that gets short circuited, so were never actually
executed. Fixing the short circuit so they do execute reveals the
filecheck assertions no longer pass. Remove them for now given they did
not exist in the original test.
This would cause failures on the internal shell given the ()
syntax is not understood by the internal shell.