[HLSL][SPIR-V] Implement vk::push_constant #166793
Draft
+85
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-perron
reviewed
Nov 10, 2025
clang/lib/Sema/SemaHLSL.cpp
Outdated
Comment on lines
3853
to
3854
| !VD->hasAttr<HLSLVkConstantIdAttr>() && | ||
| !VD->hasAttr<HLSLVkPushConstantAttr>() && |
Contributor
There was a problem hiding this comment.
I think this is where we should be ignoring the vk::push_constant attribuute if we are not targeting spir-v.
We might need to fix up the vk:constant_id attribute as well, but that is not your problem.
Contributor
Author
There was a problem hiding this comment.
Right, and I should also add a test targeting DXIL but using vk::push_constant
TODO: - get the wg-hlsl proposal accepted. - fill this description. - add tests
Keenuts
force-pushed
the
push-constants
branch
from
8576183 to
d326ece
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: