[NFCI][lldb][test][Recognizer] Fix mismatched C/C++ frontend subtitutions #167220
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions The explicit language specifications for Objective C/C++ don't seem necessary either so I've removed them too. I found these by using Clang frontend configuration files containing language-specific options for both C and C++ (e.g. `-std=c2y` and `-std=c++26`). Prior-art: 21041c9
Member
|
@llvm/pr-subscribers-lldb Author: Raul Tambre (tambry) ChangesThe explicit language specifications for Objective C/C++ don't seem necessary either so I've removed them too. I found these by using Clang frontend configuration files containing language-specific options for both C and C++ (e.g. Prior-art: 21041c9 Full diff: https://github.com/llvm/llvm-project/pull/167220.diff 2 Files Affected:
diff --git a/lldb/test/Shell/Recognizer/registration-unique.test b/lldb/test/Shell/Recognizer/registration-unique.test
index 34400d9a27575..e9641923faedf 100644
--- a/lldb/test/Shell/Recognizer/registration-unique.test
+++ b/lldb/test/Shell/Recognizer/registration-unique.test
@@ -5,16 +5,16 @@
# RUN: split-file %s %t
-# RUN: %clang_host %t/main.cpp -g -o %t/cpp.out
+# RUN: %clangxx_host %t/main.cpp -g -o %t/cpp.out
# RUN: %lldb -b -s %t/commands.input %t/cpp.out | FileCheck %s
-# RUN: %clang_host -x objective-c++ %t/main.mm -g -o %t/objcxx.out
+# RUN: %clangxx_host %t/main.mm -g -o %t/objcxx.out
# RUN: %lldb -b -s %t/commands.input %t/objcxx.out | FileCheck %s
# RUN: %clang_host %t/main.c -g -o %t/c.out
# RUN: %lldb -b -s %t/commands.input %t/c.out | FileCheck %s
-# RUN: %clang_host -x objective-c %t/main.m -g -o %t/objc.out
+# RUN: %clang_host %t/main.m -g -o %t/objc.out
# RUN: %lldb -b -s %t/commands.input %t/objc.out | FileCheck %s
#--- main.m
diff --git a/lldb/test/Shell/Recognizer/verbose_trap-objc.test b/lldb/test/Shell/Recognizer/verbose_trap-objc.test
index 789e79c9542c5..0dbb04e0fd671 100644
--- a/lldb/test/Shell/Recognizer/verbose_trap-objc.test
+++ b/lldb/test/Shell/Recognizer/verbose_trap-objc.test
@@ -1,6 +1,6 @@
# REQUIRES: system-darwin
#
-# RUN: %clangxx_host -x objective-c -g %S/Inputs/verbose_trap.m -o %t.out
+# RUN: %clang_host -g %S/Inputs/verbose_trap.m -o %t.out
# RUN: %lldb -b -s %s %t.out | FileCheck %s
run
|
Michael137
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit language specifications for Objective C/C++ don't seem necessary either so I've removed them too.
I found these by using Clang frontend configuration files containing language-specific options for both C and C++ (e.g.
-std=c2yand-std=c++26).Prior-art: 21041c9