Skip to content

libunwind: Remove OS requirements from tests to make them run on more OSes #167642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
+21 −11
Merged

libunwind: Remove OS requirements from tests to make them run on more OSes #167642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libunwind/test/aarch64_vg_unwind.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
//
//===----------------------------------------------------------------------===//

// REQUIRES: linux && target={{aarch64-.+}}
// REQUIRES: target={{aarch64-.+}}
// UNSUPPORTED: target={{.*-windows.*}}

#include <libunwind.h>
#include <stdlib.h>
Expand Down
3 changes: 2 additions & 1 deletion libunwind/test/aarch64_za_unwind.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
//
//===----------------------------------------------------------------------===//

// REQUIRES: linux && target={{aarch64-.+}}
// REQUIRES: target={{aarch64-.+}}
// UNSUPPORTED: target={{.*-windows.*}}

#include <libunwind.h>
#include <stdint.h>
Expand Down
3 changes: 2 additions & 1 deletion libunwind/test/bad_unwind_info.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
// Ensure that libunwind doesn't crash on invalid info; the Linux aarch64
// sigreturn frame check would previously attempt to access invalid memory in
// this scenario.
// REQUIRES: target={{(aarch64|s390x|x86_64)-.+linux.*}}
// REQUIRES: target={{(aarch64|s390x|x86_64)-.+}}
// UNSUPPORTED: target={{.*-windows.*}}

// GCC doesn't support __attribute__((naked)) on AArch64.
// UNSUPPORTED: gcc
Expand Down
5 changes: 3 additions & 2 deletions libunwind/test/eh_frame_fde_pc_range.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,16 @@

// clang-format off

// REQUIRES: target={{x86_64-.+-linux-gnu}}
// REQUIRES: target={{x86_64-.+}}
// REQUIRES: objcopy-available
// UNSUPPORTED: target={{.*-windows.*}}

// TODO: Figure out why this fails with Memory Sanitizer.
// XFAIL: msan

// RUN: %{build}
// RUN: %{objcopy} --dump-section .eh_frame_hdr=%t_ehf_hdr.bin %t.exe
// RUN: echo -ne '\xFF' | dd of=%t_ehf_hdr.bin bs=1 seek=2 count=2 conv=notrunc status=none
Copy link
Member

@arichardson arichardson Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this is still failing, echo should be a python built-in by default now. But fixing this to be more portable is good anyway (@boomanaiden154)

Copy link
Member

@mstorsjo mstorsjo Nov 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is still failing on x86_64 mingw:

  # .---command stdout------------
  # | 123
  # | fde_pc = 00007FF64AE46030
  # | fde_fpc = 0000000000000000
  # | fde_fpc1 = 00007FF64AE46024
  # `-----------------------------
  # .---command stderr------------
  # | libunwind: 	pc not in table, pc=0x7FF64AE413E0
  # | Assertion failed: fde_fpc != NULL, file D:\a\llvm-project\llvm-project\libunwind\test\eh_frame_fde_pc_range.pass.cpp, line 51
  # `-----------------------------
  # error: command failed with exit status: 0xffffffff

So this probably still needs an exclusion for that. (And it's probably relevant to make it generic for all of windows again - libunwind isn't normally built and tested in msvc environments, so whatever issue there is is probably specific to all of windows, not windows-gnu in particular.)

// RUN: printf '\377' | dd of=%t_ehf_hdr.bin bs=1 seek=2 count=2 conv=notrunc status=none
// RUN: %{objcopy} --update-section .eh_frame_hdr=%t_ehf_hdr.bin %t.exe
// RUN: %{exec} %t.exe

Expand Down
3 changes: 2 additions & 1 deletion libunwind/test/floatregister.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
//
//===----------------------------------------------------------------------===//

// REQUIRES: linux && target={{aarch64-.+}}
// REQUIRES: target={{aarch64-.+}}
// UNSUPPORTED: target={{.*-windows.*}}

// Basic test for float registers number are accepted.

Expand Down
4 changes: 3 additions & 1 deletion libunwind/test/forceunwind.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
//
//===----------------------------------------------------------------------===//

// REQUIRES: linux
// UNSUPPORTED: target={{.*-apple.*}}
// UNSUPPORTED: target={{.*-aix.*}}
// UNSUPPORTED: target={{.*-windows.*}}

// TODO: Figure out why this fails with Memory Sanitizer.
// XFAIL: msan
Expand Down
3 changes: 2 additions & 1 deletion libunwind/test/remember_state_leak.pass.sh.s
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
#
#===------------------------------------------------------------------------===#

# REQUIRES: target={{x86_64-.+-linux-gnu}}
# REQUIRES: target={{x86_64-.+}}
# UNSUPPORTED: target={{.*-windows.*}}

# Inline assembly isn't supported by Memory Sanitizer
# UNSUPPORTED: msan
Expand Down
3 changes: 2 additions & 1 deletion libunwind/test/signal_unwind.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
//===----------------------------------------------------------------------===//

// Ensure that the unwinder can cope with the signal handler.
// REQUIRES: target={{(aarch64|loongarch64|riscv64|s390x|x86_64)-.+linux.*}}
// REQUIRES: target={{(aarch64|loongarch64|riscv64|s390x|x86_64)-.+}}
// UNSUPPORTED: target={{.*-windows.*}}

// TODO: Figure out why this fails with Memory Sanitizer.
// XFAIL: msan
Expand Down
3 changes: 2 additions & 1 deletion libunwind/test/unwind_leaffunction.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
//===----------------------------------------------------------------------===//

// Ensure that leaf function can be unwund.
// REQUIRES: target={{(aarch64|loongarch64|riscv64|s390x|x86_64)-.+linux.*}}
// REQUIRES: target={{(aarch64|loongarch64|riscv64|s390x|x86_64)-.+}}
// UNSUPPORTED: target={{.*-windows.*}}

// TODO: Figure out why this fails with Memory Sanitizer.
// XFAIL: msan
Expand Down
2 changes: 1 addition & 1 deletion libunwind/test/unwind_scalable_vectors.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
//
//===----------------------------------------------------------------------===//

// REQUIRES: linux && target={{riscv64-.+}}
// REQUIRES: target={{riscv64-.+}}

#undef NDEBUG
#include <assert.h>
Expand Down
Loading