From 27934f7d6c5ed7f421c7864918c5f2d398cc7fe7 Mon Sep 17 00:00:00 2001 From: Adrian Vogelsgesang Date: Thu, 13 Nov 2025 01:10:09 +0000 Subject: [PATCH] [lldb] Fix command line of `target frame-provider register` So far, the syntax was > target frame-provider register [] Note the optional `run-args` at the end. They are completely ignored by the actual command, but the command line parser still accepts them. This commit removes them. They were probably a copy-paste error from `CommandObjectProcessLaunch` which was probably used as a blue-print for `target frame-provider register`. --- lldb/source/Commands/CommandObjectTarget.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp index 86373f5280271..e019264cafda3 100644 --- a/lldb/source/Commands/CommandObjectTarget.cpp +++ b/lldb/source/Commands/CommandObjectTarget.cpp @@ -5419,8 +5419,6 @@ class CommandObjectTargetFrameProviderRegister : public CommandObjectParsed { m_all_options.Append(&m_class_options, LLDB_OPT_SET_1 | LLDB_OPT_SET_2, LLDB_OPT_SET_ALL); m_all_options.Finalize(); - - AddSimpleArgumentList(eArgTypeRunArgs, eArgRepeatOptional); } ~CommandObjectTargetFrameProviderRegister() override = default; @@ -5433,7 +5431,7 @@ class CommandObjectTargetFrameProviderRegister : public CommandObjectParsed { } protected: - void DoExecute(Args &launch_args, CommandReturnObject &result) override { + void DoExecute(Args &command, CommandReturnObject &result) override { ScriptedMetadataSP metadata_sp = std::make_shared( m_class_options.GetName(), m_class_options.GetStructuredData());