-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[AMDGPU] Adding instruction specific features #167809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
eccc491
d6d1d87
3327654
83b9e8d
04413e2
cd83519
15e6eec
c6ac0f1
a3987b1
2b6be97
3691fc9
6a8d41a
91bd908
c8d8011
b6ad1ac
7d3d397
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -901,6 +901,48 @@ def FeaturePkFmacF16Inst : SubtargetFeature<"pk-fmac-f16-inst", | |||||
| "Has v_pk_fmac_f16 instruction" | ||||||
| >; | ||||||
|
|
||||||
| def FeatureVCUBEInsts : SubtargetFeature<"V_CUBE-Insts", | ||||||
| "HasVCUBEInsts", | ||||||
| "true", | ||||||
| "Has V_CUBE* instructions" | ||||||
|
||||||
| "Has V_CUBE* instructions" | |
| "Has v_cube* instructions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and all the new features
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only one instruction.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a weird name/description because v_cvt_pk_norm_i16_f32/v_cvt_pk_norm_u16_f32 are only VOP2 on GFX6-7, they are VOP3 only on newer hardware.
Maybe something like Has V_CVT_PK_NORM_*_F32 instructions/Has V_CVT_PK_NORM_*_F16 instructions would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't follow feature naming scheme, no caps